Skip to content

add tests for #26873 - #30408

Merged
bors merged 1 commit into
rust-lang:masterfrom
durka:issue-26873
Dec 19, 2015
Merged

add tests for #26873#30408
bors merged 1 commit into
rust-lang:masterfrom
durka:issue-26873

Conversation

@durka

Copy link
Copy Markdown
Contributor

I think we can close#26873 with these tests.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

Copy link
Copy Markdown
Member

Looks like there are some tidy errors (license related), but other than that lgtm

@durka

Copy link
Copy Markdown
ContributorAuthor

Bah, 2/2 so far on forgetting to copy the license into tests.

@durka

Copy link
Copy Markdown
ContributorAuthor

Fixed, I think.

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ 88ed7b7

Manishearth added a commit to Manishearth/rust that referenced this pull request Dec 16, 2015
@durka

Copy link
Copy Markdown
ContributorAuthor

That test failure makes no sense.

@durka

Copy link
Copy Markdown
ContributorAuthor

@bors retry

@durka

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton could you restart the test? I think it started in the middle of a force-push or something.

Manishearth added a commit to Manishearth/rust that referenced this pull request Dec 17, 2015
@alexcrichton

Copy link
Copy Markdown
Member

This is in the queue, it just hasn't hit bors yet

@durka

Copy link
Copy Markdown
ContributorAuthor

Oh, got it.

@Manishearth

Copy link
Copy Markdown
Member

@mitaa

Copy link
Copy Markdown
Contributor

I did some printf debugging:
Rust is for some reason looking for the module in the directory /home/mitaa/dev/rust instead of /home/mitaa/dev/rust/src/test/run-pass when running the pretty test

I guess // ignore-pretty should be acceptable for now (like the few other tests with mod directives)

bors added a commit that referenced this pull request Dec 18, 2015
@durka

Copy link
Copy Markdown
ContributorAuthor

Seems like a bug in the prettifier. Anyway, workaround added.

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ 3da609f

@bors

bors commented Dec 19, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 3da609f with merge fec739b...

bors added a commit that referenced this pull request Dec 19, 2015
@bors
bors merged commit 3da609f into rust-lang:masterDec 19, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unresolved import using separate files, but not mod statements

7 participants

@durka@rust-highfive@alexcrichton@Manishearth@mitaa@bors@brson