Improve the error explanations for check_const by arielb1 · Pull Request #30932 · rust-lang/rust

arielb1 · 2016-01-15T12:43:05Z

Fixes#30705

r? @nagisa

GuillaumeGomez · 2016-01-15T14:36:53Z

"// ..and also"? Isn't "// ... and also" better?

nagisa · 2016-01-15T16:58:38Z

Looks like an overall improvement.

arielb1 · 2016-01-15T21:53:17Z

improved

mahkoh · 2016-01-15T21:54:09Z

This is wrong. This document already contains various cases of wrong advice.

If the problem is that you need the value behind a pointer in a static variable, then not putting the value in a static variable does not fix the problem.

It's not like you can solve the problem.

I am not sure how important is the "how to fix this" advice, because each issue will have its own fix.

nagisa · 2016-01-15T23:13:43Z

Nit: This paragraph should use inline code for the constant names.

nagisa · 2016-01-15T23:16:58Z

r=me once the two nits are fixed.

arielb1 · 2016-01-19T18:42:10Z

fixed ^

nagisa · 2016-01-19T18:56:18Z

@bors r+ cad3882

nagisa · 2016-01-19T18:56:39Z

@bors rollup

bors · 2016-01-21T17:14:35Z

☔ The latest upstream changes (presumably #31024) made this pull request unmergeable. Please resolve the merge conflicts.

- Successful merges: #30997, #31019, #31031, #31035, #31045, #31050, #31054, #31055, #31061, #31088, #31090, #31111, #31113, #31128, #31130, #31136, #31145, #31146 - Failed merges: #30932

bors · 2016-01-23T18:15:59Z

🔒 Merge conflict

Fixesrust-lang#30705

arielb1 · 2016-01-24T15:16:18Z

@bors r=nagisa rollup

bors · 2016-01-24T15:16:19Z

📌 Commit 47593da has been approved by nagisa

rust-highfive assigned nagisa Jan 15, 2016

GuillaumeGomez reviewed Jan 15, 2016
View reviewed changes

Comment threadsrc/librustc/diagnostics.rs Outdated
GuillaumeGomezJan 15, 2016
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"// ..and also"? Isn't "// ... and also" better?

mahkoh reviewed Jan 15, 2016
View reviewed changes

arielb1 force-pushed the raw-const-errors branch from ba50fa0 to 5e16148Compare January 15, 2016 22:44

nagisa reviewed Jan 15, 2016
View reviewed changes

Comment threadsrc/librustc/diagnostics.rs Outdated
nagisaJan 15, 2016
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This paragraph should use inline code for the constant names.

arielb1 force-pushed the raw-const-errors branch from 5e16148 to cad3882Compare January 19, 2016 18:42

This was referenced Jan 23, 2016
Rollup of 19 pull requests #31147
Closed
Rollup of 18 pull requests #31148
Merged

Improve the error explanations for check_const
47593da
Fixesrust-lang#30705

arielb1 force-pushed the raw-const-errors branch from cad3882 to 47593daCompare January 24, 2016 15:16

Uh oh!

Uh oh!

Conversation

arielb1 commented Jan 15, 2016

Uh oh!

GuillaumeGomezJan 15, 2016

Choose a reason for hiding this comment

Uh oh!

nagisa commented Jan 15, 2016

Uh oh!

arielb1 commented Jan 15, 2016

Uh oh!

mahkohJan 15, 2016

Choose a reason for hiding this comment

Uh oh!

arielb1Jan 15, 2016

Choose a reason for hiding this comment

Uh oh!

mahkohJan 15, 2016

Choose a reason for hiding this comment

Uh oh!

arielb1Jan 15, 2016

Choose a reason for hiding this comment

Uh oh!

arielb1Jan 15, 2016

Choose a reason for hiding this comment

Uh oh!

nagisaJan 15, 2016

Choose a reason for hiding this comment

Uh oh!

nagisa commented Jan 15, 2016

Uh oh!

arielb1 commented Jan 19, 2016

Uh oh!

nagisa commented Jan 19, 2016

Uh oh!

nagisa commented Jan 19, 2016

Uh oh!

bors commented Jan 21, 2016

Uh oh!

bors commented Jan 23, 2016

Uh oh!

arielb1 commented Jan 24, 2016

Uh oh!

bors commented Jan 24, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants