Uh oh!
There was an error while loading. Please reload this page.
book: Clarify that trait or type must be in same crate as impl - #31128
Conversation
kamalmarhubi
commented
Jan 22, 2016
rust-highfive
commented
Jan 22, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
kamalmarhubi
commented
Jan 22, 2016
@bors rollup |
kamalmarhubi
commented
Jan 22, 2016
Or something :p |
kamalmarhubi
commented
Jan 22, 2016
Since the chapter on traits comes before the one on crates, would it make sense to either quick-define crates or reference the chapter? |
steveklabnik
commented
Jan 22, 2016
Yes, we need a forward reference to the crates chapter. (and @bors will only listen to people with permission 😉 ) |
kamalmarhubi
commented
Jan 22, 2016
Of course. And done. |
steveklabnik
commented
Jan 22, 2016
@bors: r+ rollup thank you so much! |
bors
commented
Jan 22, 2016
📌 Commit a559577 has been approved by |
No description provided.