Uh oh!
There was an error while loading. Please reload this page.
Documentation change: Now showing the difference between map and and_then with an example. - #30971
Conversation
rust-highfive
commented
Jan 17, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
alexcrichton
commented
Jan 17, 2016
Thanks! Could you also wrap the lines to 80 chars (appears to be the surrounding style). For the actual content, though: |
sandeep-datta
commented
Jan 18, 2016
I just felt the manually inserted 80 char wide line breaks are an anachronism in this day and age. Almost all editors can do word wrapping now. The reader should be given a choice of where they want to see the line breaks instead of making this decision for them. IMO line breaks should only be used to delineate paragraphs. Also I think unnecessary hard line breaks will make whitespace significant during file merge/comparison and make it unnecessarily hard to contribute. For example you might overflow the 80 char limit when adding a word to a line and end up with a cascading change which affects multiple lines thus making it difficult to see what was actually changed. There may be other complications arising out of this decision. I vote for removing hard line breaks from the document altogether. But I do not want to upset the apple cart on the other hand so please let me know if you would like to go with ...
|
alexcrichton
commented
Jan 18, 2016
Er sorry but this is just the style we use, changing it isn't really within the scope of this PR. |
sandeep-datta
commented
Jan 20, 2016
@alexcrichton, changed to 80 char column now. |
steveklabnik
commented
Jan 20, 2016
@bors: r+ rollup Thank you! |
bors
commented
Jan 20, 2016
📌 Commit 5f20143 has been approved by |
bors
commented
Jan 23, 2016
⌛ Testing commit 5f20143 with merge 1998e3a... |
bors
commented
Jan 23, 2016
💔 Test failed - auto-mac-64-nopt-t |
There was a problem hiding this comment.
this needs to be marked ignore as well, so that it doesn't get tested.
Updated documentation to clarify the difference between `and_then` and `map`. This also explains why we need `and_then` in addition to `map`. Please look at the diff for more information. r? @alexcrichton
steveklabnik
commented
Jan 23, 2016
@bors: r- |
sandeep-datta
commented
Jan 31, 2016
@steveklabnik please review and commit. |
steveklabnik
commented
Feb 1, 2016
@bors: r+ rollup thank you! |
bors
commented
Feb 1, 2016
📌 Commit 0922d7e has been approved by |
Updated documentation to clarify the difference between `and_then` and `map`. This also explains why we need `and_then` in addition to `map`. Please look at the diff for more information. r? @alexcrichton
Updated documentation to clarify the difference between `and_then` and `map`. This also explains why we need `and_then` in addition to `map`. Please look at the diff for more information. r? @alexcrichton
Updated documentation to clarify the difference between
and_thenandmap. This also explains why we needand_thenin addition tomap. Please look at the diff for more information.r? @alexcrichton