Uh oh!
There was an error while loading. Please reload this page.
book: Change "Failures" to "Errors" in doc special sections chapter - #31345
Conversation
This matches the usage in the standard library's documentation.
rust-highfive
commented
Feb 1, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
steveklabnik
commented
Feb 1, 2016
Hmmm, I would like to hear what @rust-lang/libs has to say about this. "Failures" is the term we agreed upon when we changed However, we may want to change that convention to |
kamalmarhubi
commented
Feb 1, 2016
Eep, I certainly wasn't expecting to be reporting a doc bug for the entire stdlib! |
aturon
commented
Feb 1, 2016
I think the book should be consistent with |
brson
commented
Feb 2, 2016
I think |
steveklabnik
commented
Feb 2, 2016
Great, let's do it! @kamalmarhubi would you like to also double-check |
kamalmarhubi
commented
Feb 2, 2016
:-) |
kamalmarhubi
commented
Feb 2, 2016
And just in case: |
steveklabnik
commented
Feb 2, 2016
What about just "failure" without the s? On Feb 1, 2016, 21:23 -0500, Kamal Marhubinotifications@github.com, wrote:
|
kamalmarhubi
commented
Feb 2, 2016
Urg, a bunch in |
kamalmarhubi
commented
Feb 2, 2016
There you go! |
steveklabnik
commented
Feb 2, 2016
@bors: r+ rollup thanks so much! |
bors
commented
Feb 2, 2016
📌 Commit 129a623 has been approved by |
…ion-errors, r=steveklabnik This matches the usage in the standard library's documentation.
This matches the usage in the standard library's documentation.