diagnostics: make paths to external items more visible by jseyfried · Pull Request #32439 · rust-lang/rust

jseyfried · 2016-03-23T02:04:53Z

This PR changes the reported path for an external item so that it is visible from at least one local module (i.e. it does not use any inaccessible external modules) if possible. If the external item's crate was declared with an extern crate, the path is guarenteed to use the extern crate.

Fixes#23224, fixes#23355, fixes#26635, fixes#27165.

r? @nrc

alexcrichton · 2016-03-23T06:12:42Z

Holy cow I thought I'd never live to see the day this got implemented.

Thank you @jseyfried!

🍰

mitaa · 2016-03-23T07:31:25Z

Nice!

FYI, with #32293 there is also a refactoring going on here which lands soon. (8500e5b, ...)

arielb1 · 2016-03-23T08:40:51Z

Why the RefMut?

The RefCell has to be borrowed mutably in this function and I didn't want to needlessly re-borrow it immutably before returning. This function is only used in librustc_metadata so I don't think it makes much difference.

Could you document this function please?

nrc · 2016-03-24T08:56:41Z

nit: spread over 3 lines

nrc · 2016-03-24T09:01:04Z

r+ with the nits addressed

jseyfried · 2016-03-25T08:15:47Z

@nrc thanks for the feedback! I addressed your comments in the most recent commit.

We should probably wait for #32293 to land before merging this since there will be non-trivial conflicts (cc @nikomatsakis).

bors · 2016-03-26T03:36:51Z

☔ The latest upstream changes (presumably #32293) made this pull request unmergeable. Please resolve the merge conflicts.

eddyb · 2016-03-29T18:42:27Z

@jseyfried I think this can be r=nrc with src/test/pretty/issue-4264.pp updated to use the new paths (see travis failure).

jseyfried · 2016-03-30T23:09:25Z

@bors r=nrc

bors · 2016-03-30T23:09:25Z

📌 Commit da41e58 has been approved by nrc

bors · 2016-03-31T04:13:44Z

⌛ Testing commit da41e58 with merge 4583dc9...

@nrc

diagnostics: make paths to external items more visible This PR changes the reported path for an external item so that it is visible from at least one local module (i.e. it does not use any inaccessible external modules) if possible. If the external item's crate was declared with an `extern crate`, the path is guarenteed to use the `extern crate`. Fixes#23224, fixes#23355, fixes#26635, fixes#27165. r? @nrc

bors · 2016-03-31T15:05:45Z

💥 Test timed out

eddyb · 2016-03-31T15:07:47Z

@bors force retry

eddyb · 2016-03-31T15:08:07Z

@bors p=1

alexcrichton · 2016-03-31T16:02:59Z

This ended up passing all tests on bors, not sure what happened here so I'm just gonna merge manually

rust-highfive assigned nrc Mar 23, 2016

jseyfried force-pushed the visible_suggestions branch from c4c4f58 to 1923d1cCompare March 23, 2016 05:20

jseyfried force-pushed the visible_suggestions branch 2 times, most recently from 6dfa268 to 4f87af1Compare March 23, 2016 06:44

jseyfried force-pushed the visible_suggestions branch from 4f87af1 to 62d6ea4Compare March 23, 2016 07:51

arielb1 reviewed Mar 23, 2016
View reviewed changes

jseyfried force-pushed the visible_suggestions branch from 62d6ea4 to 82da520Compare March 23, 2016 08:56

nrc reviewed Mar 24, 2016
View reviewed changes

Comment threadsrc/librustc_metadata/cstore.rs Outdated
nrcMar 24, 2016
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: spread over 3 lines

jseyfried force-pushed the visible_suggestions branch 3 times, most recently from ccc40dc to 17e8ce8Compare March 25, 2016 06:53

jseyfried force-pushed the visible_suggestions branch 6 times, most recently from e43422e to 6ac1799Compare March 29, 2016 06:55

jseyfried force-pushed the visible_suggestions branch 3 times, most recently from 8183ec4 to d5ea770Compare March 30, 2016 01:05

jseyfried added 2 commits March 30, 2016 22:00

Add method visible_item_path to CStore
0c6f067

Fix fallout in tests
da41e58

jseyfried force-pushed the visible_suggestions branch from d5ea770 to da41e58Compare March 30, 2016 22:03

alexcrichton merged commit da41e58 into rust-lang:masterMar 31, 2016

This was referenced Mar 31, 2016
Reorganize rustc_front into rustc::hir. #32570
Merged
process cycles as soon as they are detected #32582
Merged
Suggest adding a where-clause when that can help #32583
Merged

mcarton mentioned this pull request Apr 1, 2016
Fix false positive with DOC_MARKDOWN and links + rustup rust-lang/rust-clippy#824
Merged

Uh oh!

Uh oh!

Conversation

jseyfried commented Mar 23, 2016

Uh oh!

alexcrichton commented Mar 23, 2016

Uh oh!

mitaa commented Mar 23, 2016

Uh oh!

arielb1Mar 23, 2016

Choose a reason for hiding this comment

Uh oh!

jseyfriedMar 23, 2016

Choose a reason for hiding this comment

Uh oh!

nrcMar 24, 2016

Choose a reason for hiding this comment

Uh oh!

jseyfriedMar 25, 2016

Choose a reason for hiding this comment

Uh oh!

nrcMar 24, 2016

Choose a reason for hiding this comment

Uh oh!

nrc commented Mar 24, 2016

Uh oh!

jseyfried commented Mar 25, 2016

Uh oh!

bors commented Mar 26, 2016

Uh oh!

eddyb commented Mar 29, 2016

Uh oh!

jseyfried commented Mar 30, 2016

Uh oh!

bors commented Mar 30, 2016

Uh oh!

bors commented Mar 31, 2016

Uh oh!

bors commented Mar 31, 2016

Uh oh!

eddyb commented Mar 31, 2016

Uh oh!

eddyb commented Mar 31, 2016

Uh oh!

alexcrichton commented Mar 31, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants