Suggest adding a where-clause when that can help by arielb1 · Pull Request #32583 · rust-lang/rust

arielb1 · 2016-03-29T17:17:39Z

Suggest adding a where-clause when there is an unmet trait-bound that can be satisfied if some type can implement it.

bors · 2016-03-31T16:04:39Z

☔ The latest upstream changes (presumably #32439) made this pull request unmergeable. Please resolve the merge conflicts.

nikomatsakis · 2016-04-04T17:53:08Z

Hmm, I wonder if it is better to write in this uniform style, or to try to have a custom error message? Not clear to me. It seems likely that if we are going to make this message generic, we could combine with some other error-code -- though maybe there is value in separating out this form of predicate from the others. NM, keep it with its own code.

nikomatsakis · 2016-04-04T18:01:53Z

Everything looks good, I'd like to review the comments though, just because I'd like to ensure this is well documented for future reference (and to make sure we are on same page)

nikomatsakis · 2016-04-04T19:16:12Z

@arielb1

That's the impl Display for TraitRef.

Yes, I know, I was suggesting changing it to remove the space.

now that normalize_to_error no longer creates these, it is unnecessary.

suggest adding a where-clause when there is an unmet trait-bound that can be satisfied if some type can implement it.

the meaning of these tests had changed completely over the years and now they are only a maintenance burden.

nikomatsakis · 2016-04-05T20:27:04Z

@bors r+

bors · 2016-04-05T20:27:05Z

📌 Commit 832b707 has been approved by nikomatsakis

bors · 2016-04-06T00:27:58Z

⌛ Testing commit 832b707 with merge c7a6876...

bors · 2016-04-06T01:58:22Z

💔 Test failed - auto-linux-64-opt

arielb1 · 2016-04-06T19:00:39Z

@bors r=nikomatsakis

bors · 2016-04-06T19:00:40Z

📌 Commit 32fc7c3 has been approved by nikomatsakis

arielb1 · 2016-04-06T20:33:46Z

@bors r=nikomatsakis

bors · 2016-04-06T20:33:47Z

📌 Commit 30d8eff has been approved by nikomatsakis

@nikomatsakis

Suggest adding a where-clause when that can help Suggest adding a where-clause when there is an unmet trait-bound that can be satisfied if some type can implement it. r? @nikomatsakis

Rollup of 11 pull requests - Successful merges: #32016, #32583, #32699, #32729, #32731, #32738, #32741, #32745, #32748, #32757, #32786 - Failed merges: #32773

bors · 2016-04-07T05:22:36Z

⌛ Testing commit 30d8eff with merge a66f46e...

bors · 2016-04-07T07:08:13Z

💔 Test failed - auto-linux-64-nopt-t

arielb1 · 2016-04-07T09:17:39Z

@bors r=nikomatsakis

bors · 2016-04-07T09:17:39Z

📌 Commit 0ac5e48 has been approved by nikomatsakis

@nikomatsakis

Suggest adding a where-clause when that can help Suggest adding a where-clause when there is an unmet trait-bound that can be satisfied if some type can implement it. r? @nikomatsakis

bors · 2016-04-07T10:07:25Z

⌛ Testing commit 0ac5e48 with merge 444a118...

bors · 2016-04-07T13:08:22Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-64-x-armhf, auto-linux-64-x-armsf, auto-linux-64-x-freebsd, auto-linux-64-x-netbsd, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

rust-highfive assigned nikomatsakis Mar 29, 2016

arielb1 force-pushed the need-a-bound branch from 0ee33a8 to b02c4a7Compare March 29, 2016 21:59

arielb1 force-pushed the need-a-bound branch 2 times, most recently from 317e7e6 to 331e612Compare March 31, 2016 19:43

nikomatsakis reviewed Apr 4, 2016
View reviewed changes

Ariel Ben-Yehudaand others added 5 commits April 5, 2016 20:58

remove workaround that prints error messages with TyErr
513d9f2
now that normalize_to_error no longer creates these, it is unnecessary.

suggest adding a where-clause when that can help
8a461d9
suggest adding a where-clause when there is an unmet trait-bound that can be satisfied if some type can implement it.

improve error message
728d20f

remove obsolete tests
31247e5
the meaning of these tests had changed completely over the years and now they are only a maintenance burden.

improve the printing of substs and trait-refs
b23648f

arielb1 force-pushed the need-a-bound branch from 331e612 to 8ceb840Compare April 5, 2016 20:20

clean the note-reporting code in report_selection_error
832b707

arielb1 force-pushed the need-a-bound branch from 8ceb840 to 832b707Compare April 5, 2016 20:25

arielb1 force-pushed the need-a-bound branch from 32fc7c3 to 30d8effCompare April 6, 2016 20:33

Manishearth mentioned this pull request Apr 7, 2016
Rollup of 11 pull requests #32787
Closed

bors added a commit that referenced this pull request Apr 7, 2016
Auto merge of#32787- Manishearth:rollup, r=Manishearth
6a55f4f
Rollup of 11 pull requests - Successful merges: #32016, #32583, #32699, #32729, #32731, #32738, #32741, #32745, #32748, #32757, #32786 - Failed merges: #32773

test the substs ppaux code both with and without -Z verbose
0ac5e48

arielb1 force-pushed the need-a-bound branch from 30d8eff to 0ac5e48Compare April 7, 2016 09:17

bors mentioned this pull request Apr 7, 2016
Rollup of 7 pull requests #32794
Merged

bors merged commit 0ac5e48 into rust-lang:masterApr 7, 2016

Uh oh!

Uh oh!

Conversation

arielb1 commented Mar 29, 2016

Uh oh!

bors commented Mar 31, 2016

Uh oh!

nikomatsakisApr 4, 2016

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented Apr 4, 2016

Uh oh!

nikomatsakis commented Apr 4, 2016

Uh oh!

nikomatsakis commented Apr 5, 2016

Uh oh!

bors commented Apr 5, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

arielb1 commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

arielb1 commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

bors commented Apr 7, 2016

Uh oh!

bors commented Apr 7, 2016

Uh oh!

arielb1 commented Apr 7, 2016

Uh oh!

bors commented Apr 7, 2016

Uh oh!

bors commented Apr 7, 2016

Uh oh!

bors commented Apr 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants