Skip to content

Update a comment to reflect changes in tidy checks. - #32929

Merged
bors merged 1 commit into
rust-lang:masterfrom
LeoTestard:featureck-comment
Apr 16, 2016
Merged

Update a comment to reflect changes in tidy checks.#32929
bors merged 1 commit into
rust-lang:masterfrom
LeoTestard:featureck-comment

Conversation

@LeoTestard

@LeoTestardLeoTestard commented Apr 13, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Apr 13, 2016

Copy link
Copy Markdown
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez

GuillaumeGomez commented Apr 13, 2016

Copy link
Copy Markdown
Member

r= me @steveklabnik

@steveklabnik

steveklabnik commented Apr 14, 2016

Copy link
Copy Markdown
Contributor

@bors: delegate=GuillaumeGomez

@bors: r=GuillaumeGomez

@bors

bors commented Apr 14, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 340eff6 has been approved by GuillaumeGomez

@bors

bors commented Apr 14, 2016

Copy link
Copy Markdown
Collaborator

✌️ @GuillaumeGomez can now approve this pull request

@steveklabnik

steveklabnik commented Apr 14, 2016

Copy link
Copy Markdown
Contributor

@bors: r=GuillaumeGomez

@bors

bors commented Apr 14, 2016

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented Apr 14, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 340eff6 has been approved by GuillaumeGomez

@steveklabnik

steveklabnik commented Apr 14, 2016

Copy link
Copy Markdown
Contributor

ah, nice. it was approved, bors just didn't leave a message.

I will get good at this and stop spamming you all with notifications, I promise 😉

@bors

bors commented Apr 14, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 340eff6 with merge 3092040...

@bors

bors commented Apr 14, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-opt

@GuillaumeGomez

GuillaumeGomez commented Apr 14, 2016

Copy link
Copy Markdown
Member

You have too much energy @steveklabnik! :p

@GuillaumeGomez

GuillaumeGomez commented Apr 14, 2016

Copy link
Copy Markdown
Member

@bors: retry

@bors

bors commented Apr 14, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 340eff6 with merge 8278041...

@bors

bors commented Apr 14, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-opt

@alexcrichton

alexcrichton commented Apr 14, 2016

Copy link
Copy Markdown
Member

@bors: retry

On Thu, Apr 14, 2016 at 12:44 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-gnu-32-opt
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/3799

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#32929 (comment)

@ManishearthManishearth mentioned this pull request Apr 15, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 15, 2016
@Manishearth
Rollup merge ofrust-lang#32929- LeoTestard:featureck-comment, r=Gui…
7e36dc3
…llaumeGomez
Update a comment to reflect changes in tidy checks.
bors added a commit that referenced this pull request Apr 15, 2016
@bors
Auto merge of#33005- Manishearth:rollup, r=Manishearth
576229f
Rollup of 11 pull requests
- Successful merges: #32923, #32926, #32929, #32931, #32935, #32945, #32946, #32964, #32970, #32973, #32997
- Failed merges:
@bors
bors merged commit 340eff6 into rust-lang:masterApr 16, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pnkfelixpnkfelix

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@LeoTestard@rust-highfive@GuillaumeGomez@steveklabnik@bors@alexcrichton@pnkfelix