Uh oh!
There was an error while loading. Please reload this page.
Doc fix: Update Cargo.toml in book/getting-started - #32931
Conversation
rust-highfive
commented
Apr 13, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
I find this sentence a bit awkward. What about "Do not worry about the [dependencies] line, we will come back to it later."?
There was a problem hiding this comment.
thanks. reads better.
have made the change and rebased
The Cargo.toml mentioned in book/getting-started is missing the section called `[dependencies]`
0d87443 to
722faa0CompareGuillaumeGomez
commented
Apr 13, 2016
Thanks! r=me @steveklabnik |
steveklabnik
commented
Apr 13, 2016
@bors: delegate=@GuillaumeGomez |
bors
commented
Apr 13, 2016
✌️ @@GuillaumeGomez can now approve this pull request |
bors
commented
Apr 13, 2016
📌 Commit 722faa0 has been approved by |
steveklabnik
commented
Apr 13, 2016
whoops @bors: delegate=GuillaumeGomez |
bors
commented
Apr 13, 2016
✌️ @GuillaumeGomez can now approve this pull request |
steveklabnik
commented
Apr 13, 2016
@bors: r=GuillaumeGomez |
bors
commented
Apr 13, 2016
💡 This pull request was already approved, no need to approve it again.
|
bors
commented
Apr 13, 2016
📌 Commit 722faa0 has been approved by |
bors
commented
Apr 14, 2016
⌛ Testing commit 722faa0 with merge 21161a4... |
bors
commented
Apr 14, 2016
💔 Test failed - auto-win-gnu-32-opt |
alexcrichton
commented
Apr 14, 2016
@bors: retry On Thu, Apr 14, 2016 at 12:26 PM, bors notifications@github.com wrote:
|
…in-getting-started-doc, r=GuillaumeGomez Doc fix: Update Cargo.toml in book/getting-started The Cargo.toml mentioned in book/getting-started is missing the section called `[dependencies]` fixesrust-lang#32928
The Cargo.toml mentioned in book/getting-started
is missing the section called
[dependencies]fixes#32928