Skip to content

Fix link in contributing page - #33003

Merged
bors merged 1 commit into
rust-lang:masterfrom
floftar:link
Apr 17, 2016
Merged

Fix link in contributing page#33003
bors merged 1 commit into
rust-lang:masterfrom
floftar:link

Conversation

@floftar

@floftarfloftar commented Apr 15, 2016

Copy link
Copy Markdown
Contributor

Link was broken (404).

@rust-highfive

rust-highfive commented Apr 15, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik

steveklabnik commented Apr 15, 2016

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

thank you!

@bors

bors commented Apr 15, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit daa48a2 has been approved by steveklabnik

@bors

bors commented Apr 16, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit daa48a2 with merge 665facb...

@bors

bors commented Apr 16, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton

alexcrichton commented Apr 16, 2016

Copy link
Copy Markdown
Member

@bors: retry

On Sat, Apr 16, 2016 at 6:19 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-gnu-32-opt-rustbuild
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/737

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#33003 (comment)

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2016
@Manishearth
Rollup merge ofrust-lang#33003- fbergr:link, r=steveklabnik
31bedab
Fix link in contributing page
Link was broken (404).
@ManishearthManishearth mentioned this pull request Apr 17, 2016
Merged
bors added a commit that referenced this pull request Apr 17, 2016
@bors
Auto merge of#33049- Manishearth:rollup, r=Manishearth
a626400
Rollup of 10 pull requests
- Successful merges: #31441, #32956, #33003, #33022, #33023, #33032, #33039, #33044, #33045, #33046
- Failed merges:
@bors
bors merged commit daa48a2 into rust-lang:masterApr 17, 2016
@floftar
floftar deleted the link branch April 17, 2016 14:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@floftar@rust-highfive@steveklabnik@bors@alexcrichton@nikomatsakis