Uh oh!
There was an error while loading. Please reload this page.
Make HashSet::Insert documentation more consistent - #33152
Conversation
rust-highfive
commented
Apr 22, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
mitaa
commented
Apr 22, 2016
Could you also update / make this consistent with |
steveklabnik
commented
Apr 26, 2016
bors
commented
Apr 26, 2016
📌 Commit 3e9ea3b has been approved by |
Make HashSet::Insert documentation more consistent I have made the HashSet::Insert documentation more consistent in the use of the term 'value' vs 'key'. Also clarified that if _this_ value is present true is returned, instead of the ambiguous 'a value present'. r? @steveklabnik
Make HashSet::Insert documentation more consistent I have made the HashSet::Insert documentation more consistent in the use of the term 'value' vs 'key'. Also clarified that if _this_ value is present true is returned, instead of the ambiguous 'a value present'. r? @steveklabnik
I have made the HashSet::Insert documentation more consistent in the use of the term 'value' vs 'key'. Also clarified that if this value is present true is returned, instead of the ambiguous 'a value present'.
r? @steveklabnik