Uh oh!
There was an error while loading. Please reload this page.
Rollup of 8 pull requests - #33236
Closed
Manishearth wants to merge 19 commits into
Closed
Conversation
Opening sentence was confusing and something cannot be "one of the most unique" (it either is or is not unique).
…st unique" (it either is or is not unique).
…st unique" (it either is or is not unique).
add as 2nd example.
`move` work both in `cmd` and in Powershell. `mv` works only in Powershell and the book says nothing about which shell is recommended so this could confuse beginners. Closesrust-lang#33219.
rust-highfive
commented
Apr 27, 2016
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
Manishearth
commented
Apr 27, 2016
MemberAuthor
@bors r+ p=10 |
bors
commented
Apr 27, 2016
Collaborator
📌 Commit 6f74df7 has been approved by |
bors
commented
Apr 27, 2016
Collaborator
⌛ Testing commit 6f74df7 with merge 7b40ffc... |
bors
commented
Apr 27, 2016
Collaborator
💔 Test failed - auto-linux-64-opt-mir |
Manishearthforce-pushed
the
rollup
branch
2 times, most recently
from
April 27, 2016 14:56
f98c217 to
80bff1eComparemake the borrowing example more concrete
…r=steveklabnik Improve as_mut ptr method example r? @steveklabnik
Tweaks to sections related to Ownership
Reading through these sections, I thought the intro text could be improved slightly. So
here is a PR that addresses what was bugging me about it. :-)
Main issue was the wording of the opening sentence ("guide" is not clearly defined and the
wording was a bit too terse in my opinion). I also took issue with the term "one of the most
unique". Uniqueness is a `bool`, not an `f64`. :-)
r? @steveklabnikMake HashSet::Insert documentation more consistent I have made the HashSet::Insert documentation more consistent in the use of the term 'value' vs 'key'. Also clarified that if _this_ value is present true is returned, instead of the ambiguous 'a value present'. r? @steveklabnik
…nikomatsakis Improve error message about regions of function body "scope of parameters for functions" is harder for me to read than "scope of function body", I hope others feel the same, as in <https://play.rust-lang.org/?gist=b4df68b395b807698bd2ba98cf3d5ce3&version=stable&backtrace=0&run=1> Thank @Aatch for the help :)
…sakis allow InternedString to be compared to &str directly
…ch-1, r=GuillaumeGomez Fix use of the `move` command in the Windows shell `move` works both in `cmd` and in Powershell. `mv` works only in Powershell and the book says nothing about which shell is recommended so this could confuse beginners. Closesrust-lang#33219.
mir: drop temps outside-in by scheduling the drops inside-out. It was backwards all along, but only noticeable with multiple drops in one rvalue scope. Fixesrust-lang#32433.
Manishearth
commented
Apr 27, 2016
MemberAuthor
@bors-servo r+ force |
bors
commented
Apr 27, 2016
Collaborator
📌 Commit 651ae26 has been approved by |
bors
commented
Apr 27, 2016
Collaborator
bors added a commit
that referenced
this pull request
Apr 27, 2016
bors
commented
Apr 27, 2016
Collaborator
💔 Test failed - auto-linux-64-opt-mir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
movecommand in the Windows shell #33234