Uh oh!
There was an error while loading. Please reload this page.
parser: do not try to continue with unsafe on foreign fns - #33336
Merged
Conversation
rust-highfive
commented
May 2, 2016
Contributor
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
oli-obk
commented
May 2, 2016
Contributor
you need to update the |
birkenfeld
commented
May 2, 2016
ContributorAuthor
Thanks! I'll freely admit I didn't want to wait for the tests locally to find these :) |
The changed line makes it look like `unsafe` is allowed, but the first statement of `parse_item_foreign_fn` is: `self.expect_keyword(keywords::Fn)?;` So we get the strange "expected one of `fn`, `pub`, `static`, or `unsafe`, found `unsafe`". Fixes: rust-lang#27361
oli-obk
commented
May 2, 2016
Contributor
Yea, it would be great if we got emails from travis... |
sfackler
commented
May 2, 2016
Member
@bors r+ rollup |
bors
commented
May 2, 2016
Collaborator
📌 Commit b75f81c has been approved by |
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
May 5, 2016
parser: do not try to continue with `unsafe` on foreign fns The changed line makes it look like `unsafe` is allowed, but the first statement of `parse_item_foreign_fn` is: ``` self.expect_keyword(keywords::Fn)?; ``` So we get the strange "expected one of `fn`, `pub`, `static`, or `unsafe`, found `unsafe`". Fixes: rust-lang#27361
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
May 5, 2016
parser: do not try to continue with `unsafe` on foreign fns The changed line makes it look like `unsafe` is allowed, but the first statement of `parse_item_foreign_fn` is: ``` self.expect_keyword(keywords::Fn)?; ``` So we get the strange "expected one of `fn`, `pub`, `static`, or `unsafe`, found `unsafe`". Fixes: rust-lang#27361
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
May 5, 2016
parser: do not try to continue with `unsafe` on foreign fns The changed line makes it look like `unsafe` is allowed, but the first statement of `parse_item_foreign_fn` is: ``` self.expect_keyword(keywords::Fn)?; ``` So we get the strange "expected one of `fn`, `pub`, `static`, or `unsafe`, found `unsafe`". Fixes: rust-lang#27361
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
May 6, 2016
parser: do not try to continue with `unsafe` on foreign fns The changed line makes it look like `unsafe` is allowed, but the first statement of `parse_item_foreign_fn` is: ``` self.expect_keyword(keywords::Fn)?; ``` So we get the strange "expected one of `fn`, `pub`, `static`, or `unsafe`, found `unsafe`". Fixes: rust-lang#27361
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 7, 2016
parser: do not try to continue with `unsafe` on foreign fns The changed line makes it look like `unsafe` is allowed, but the first statement of `parse_item_foreign_fn` is: ``` self.expect_keyword(keywords::Fn)?; ``` So we get the strange "expected one of `fn`, `pub`, `static`, or `unsafe`, found `unsafe`". Fixes: rust-lang#27361
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
May 7, 2016
parser: do not try to continue with `unsafe` on foreign fns The changed line makes it look like `unsafe` is allowed, but the first statement of `parse_item_foreign_fn` is: ``` self.expect_keyword(keywords::Fn)?; ``` So we get the strange "expected one of `fn`, `pub`, `static`, or `unsafe`, found `unsafe`". Fixes: rust-lang#27361
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
May 7, 2016
parser: do not try to continue with `unsafe` on foreign fns The changed line makes it look like `unsafe` is allowed, but the first statement of `parse_item_foreign_fn` is: ``` self.expect_keyword(keywords::Fn)?; ``` So we get the strange "expected one of `fn`, `pub`, `static`, or `unsafe`, found `unsafe`". Fixes: rust-lang#27361
bors added a commit
that referenced
this pull request
May 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changed line makes it look like
unsafeis allowed, but the first statement ofparse_item_foreign_fnis:So we get the strange "expected one of
fn,pub,static, orunsafe, foundunsafe".Fixes: #27361