Uh oh!
There was an error while loading. Please reload this page.
Rollup of 17 pull requests - #33462
Closed
steveklabnik wants to merge 35 commits into
Closed
Conversation
On my system, when the processor is already loaded, and I try to run the test suite, e.g. compile-fail/dep-graph-assoc-type-trans.rs fails because of undecodable JSON. Running the compiler manually, I can see that the dep graph thread panics (and puts non-JSON on stderr) while `send`ing on `swap_out`, presumably because the other end has already quit. I think that in this case, we can just gracefully exit the thread.
Also move the "Thread type" section down a bit, since it is not so important anymore. Fixes: rust-lang#33321
The changed line makes it look like `unsafe` is allowed, but the first statement of `parse_item_foreign_fn` is: `self.expect_keyword(keywords::Fn)?;` So we get the strange "expected one of `fn`, `pub`, `static`, or `unsafe`, found `unsafe`". Fixes: rust-lang#27361
Removed unnecessary use of threads from E0504 Cleaned up line ending on E0504 Added more examples for E0504 Changed to erroneous code wording Switched Rc example to thread/Arc example Added comments describing why errors no longer occur
We will no longer use `ccache` in the makefiles for our local dependencies like miniz, but they're so small anyway it doesn't really matter. Closesrust-lang#33285
The definition of this value recently changed slightly. It no longer corresponds directly to the target triple. Also shuffled things around to make the order of cfg descriptions more logical and added text related them to the target triple. cc rust-lang#33403
This should be `have` instead of `has`.
Doc improvement on std::fmt module Part of rust-lang#29355. r? @steveklabnik
…les, r=nikomatsakis Add `TAGS.rustc.emacs`/`TAGS.rustc.vi` make targets Add `TAGS.rustc.emacs`/`TAGS.rustc.vi` make targets, (re-)including rustc source.
…klabnik Add process types documentation Part of rust-lang#29370. r? @steveklabnik
…tsakis dep_graph: avoid panicking in thread when channel closed On my system, when the processor is already loaded, and I try to run the test suite, e.g. compile-fail/dep-graph-assoc-type-trans.rs fails because of undecodable JSON. Running the compiler manually, I can see that the dep graph thread panics (and puts non-JSON on stderr) while `send`ing on `swap_out`, presumably because the other end has already quit. I think that in this case, we can just gracefully exit the thread.
…nkfelix mk: Fix building with --enable-ccache We will no longer use `ccache` in the makefiles for our local dependencies like miniz, but they're so small anyway it doesn't really matter. Closesrust-lang#33285
…Gomez std::thread docs: spawn() does not return a Thread anymore Also move the "Thread type" section down a bit, since it is not so important anymore. Fixes: rust-lang#33321
parser: do not try to continue with `unsafe` on foreign fns The changed line makes it look like `unsafe` is allowed, but the first statement of `parse_item_foreign_fn` is: ``` self.expect_keyword(keywords::Fn)?; ``` So we get the strange "expected one of `fn`, `pub`, `static`, or `unsafe`, found `unsafe`". Fixes: rust-lang#27361
Add detailed error explanation for E0504 Part of rust-lang#32777
…Manishearth Replace copy-pasted variable name with relevant one
Remove rust flags from doc block Fixesrust-lang#33405 r? @Manishearth
…bnik Add an example to Wrapping's documentation. Such an example would have helped me understand `Wrapping` quicker. r? @steveklabnik
[Doc] Default cpu is "generic" (and not "default") See [line 305](https://github.com/phil-opp/rust/blob/a22ca2872ef6782306012e6817dc4b8b778c43e9/src/librustc_back/target/mod.rs#L305).
doc: Update reference with better description of target_env The definition of this value recently changed slightly. It no longer corresponds directly to the target triple. Also shuffled things around to make the order of cfg descriptions more logical and added text related them to the target triple. cc rust-lang#33403
Fix some some duplicate words.
doc: make RFC references consistent Always add a space and end sentence with a full stop.
…eGomez Fix Typo in Barrier::wait documentation This should be `have` instead of `has`.
rust-highfive
commented
May 6, 2016
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
steveklabnik
commented
May 6, 2016
ContributorAuthor
@bors: r+ p=100000 |
bors
commented
May 6, 2016
Collaborator
📌 Commit eb288e7 has been approved by |
bors
commented
May 6, 2016
Collaborator
⌛ Testing commit eb288e7 with merge ab37c0e... |
bors
commented
May 6, 2016
Collaborator
💔 Test failed - auto-linux-64-opt-rustbuild |
GuillaumeGomez
commented
May 7, 2016
Member
I reopened it here to fix the issue more quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TAGS.rustc.emacs/TAGS.rustc.vimake targets #33256, Add process types documentation #33283, dep_graph: avoid panicking in thread when channel closed #33313, mk: Fix building with --enable-ccache #33314, std::thread docs: spawn() does not return a Thread anymore #33326, parser: do not try to continue withunsafeon foreign fns #33336, Add detailed error explanation for E0504 #33386, Replace copy-pasted variable name with relevant one #33402, errors in the doc #33409, Remove rust flags from doc block #33410, Add an example to Wrapping's documentation. #33428, [Doc] Default cpu is "generic" (and not "default") #33430, doc: Update reference with better description of target_env #33437, Fix some some duplicate words. #33438, doc: make RFC references consistent #33439, Fix Typo in Barrier::wait documentation #33456