Uh oh!
There was an error while loading. Please reload this page.
Improve diagnostics for constants being used in irrefutable patterns - #33406
Merged
Conversation
It's pretty confusing and this error triggers in resolve only when "shadowing" a const, so let's make that clearer.
Manishearthforce-pushed
the
diag-improve-const-let
branch
from
May 4, 2016 18:01
e2fd6d4 to
3ce8dd1CompareGuillaumeGomez
commented
May 4, 2016
Member
Hum... Like you said, it's a bit confusing when you read it. The best explanation I could find for this is maybe too much details? Hard to say. :-/ |
Manishearthforce-pushed
the
diag-improve-const-let
branch
from
May 5, 2016 04:42
3ce8dd1 to
9f302b6CompareManishearth
commented
May 5, 2016
MemberAuthor
updated |
GuillaumeGomez
commented
May 5, 2016
Member
Great job! Thanks a lot @Manishearth! r=me @steveklabnik |
Manishearth
commented
May 5, 2016
MemberAuthor
@bors r=GuillaumeGomez |
bors
commented
May 5, 2016
Collaborator
📌 Commit 9f302b6 has been approved by |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
May 8, 2016
… r=GuillaumeGomez Improve diagnostics for constants being used in irrefutable patterns It's pretty confusing and this error triggers in resolve only when "shadowing" a const, so let's make that clearer. r? @steveklabnik
bors added a commit
that referenced
this pull request
May 8, 2016
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
May 8, 2016
… r=GuillaumeGomez Improve diagnostics for constants being used in irrefutable patterns It's pretty confusing and this error triggers in resolve only when "shadowing" a const, so let's make that clearer. r? @steveklabnik
bors added a commit
that referenced
this pull request
May 8, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's pretty confusing and this error triggers in resolve only when "shadowing" a const, so let's make that clearer.
r? @steveklabnik