run rustfmt on libsyntax_ext/deriving folder

[srinivasreddy]

No description provided.

[rust-highfive]

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

[srinivasreddy]

cc @nrc

[brson]

This indentation is pretty strange. Why is the continuation line at the same level is if?

[nrc]

It's a bug, I filed rust-lang/rustfmt#1099 for this

[brson]

@nrc I'm not sure how to review these patches. They all seem to have parts that look like they might want to be tweaked. With the actual style conventions in flux, are we happy to land these with formatting that is sometimes not very attractive? What's the goal with rustfmting the compiler?

[bors]

☔ The latest upstream changes (presumably #34424) made this pull request unmergeable. Please resolve the merge conflicts.

[brson]

Triage: no change since my previous comment.

[nrc]

@brson I would like to not block patches like this on perfect formatting. I would block if we lose formatting that won't easily be recreated (e.g., a matrix alignment) or if the formatting is really gross (i.e., you would be unhappy working with such code), c.f, slightly off (such as the alignment here). Basically, I think rustfmt is going to get better and these things will naturally get better over time, but if we don't get started, we never will.

Given that, do you think this PR just needs a rebase to land, or are there other blocking issues with it? If there, it would be nice (but not essential) to file rustfmt issues and close this PR until rustfmt is fixed.

[brson]

@nrc I'm fine landing this one, though I guess @srinivasreddy will need to redo the patch at this point. Sorry for the delay @srinivasreddy.

[srinivasreddy]

@brson Let's land this cc @nrc

[brson]

@bors r+

[bors]

📌 Commit 9652fcb has been approved by brson

[brson]

Thanks @srinivasreddy

[bors]

⌛ Testing commit 9652fcb with merge 3773770...

[bors]

💔 Test failed - auto-win-gnu-32-opt-rustbuild

[alexcrichton]

@bors: retry

• Cascading failure on bots when interrupted when performing git operations #34595

On Tue, Jul 19, 2016 at 9:06 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1821

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#34113 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95KuBR-VLO3_ywwCf-zS-OLltHjRWks5qXZ66gaJpZM4IvAAf
.

[bors]

⌛ Testing commit 9652fcb with merge a07fdcd...

[bors]

💔 Test failed - auto-win-msvc-64-cargotest

[alexcrichton]

@bors: retry

On Tue, Jul 19, 2016 at 11:14 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-cargotest
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-cargotest/builds/1184

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34113 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95FKiZt2sciB3JCTuLFf0xybREf2Kks5qXbzLgaJpZM4IvAAf
.

[bors]

⌛ Testing commit 9652fcb with merge 08638de...

[bors]

💔 Test failed - auto-win-gnu-32-opt

[alexcrichton]

@bors: retry

• Spurious access violation on Windows #33434

On Wed, Jul 20, 2016 at 5:46 AM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/4977

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34113 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95JinARfYjfSBHCmObQgLdG-ebjv_ks5qXhingaJpZM4IvAAf
.

[bors]

⌛ Testing commit 9652fcb with merge 936bfea...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild
Approved by: brson
Pushing 936bfea to master...