Attributes on generic formals by pnkfelix · Pull Request #34764 · rust-lang/rust

pnkfelix · 2016-07-11T15:30:31Z

First step for #34761

rust-highfive · 2016-07-11T15:30:45Z

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

eddyb · 2016-07-11T16:59:14Z

r? @eddyb

@bors r+

bors · 2016-07-11T16:59:15Z

📌 Commit 337073b has been approved by eddyb

durka · 2016-07-11T19:38:35Z

plugin-breaking, no?

eddyb · 2016-07-11T19:41:30Z

@bors r-

Ah, yes, of course. Thanks @durka. @Manishearth r=me for the next breaking batch or whatnot.

aravind-pg · 2016-07-11T23:28:52Z

Nit: s/parsing/parse

bors · 2016-07-20T23:49:06Z

☔ The latest upstream changes (presumably #34113) made this pull request unmergeable. Please resolve the merge conflicts.

dns2utf8 · 2016-07-23T22:49:31Z

Why deref here, but not with the bounds?

Its necessary (here and below) because &bounds is a &Vec while &attrs is a &ThinVec.
Right now, you cannot iterate over a &ThinVec directly; you need to deref the ThinVec to turn it into a [T] slice that you can then iterate over.

dns2utf8 · 2016-07-23T22:51:19Z

I wonder why you used deref with the walk_list! macros, but the old code does not.

eddyb · 2016-08-01T13:19:32Z

ping @Manishearth

Manishearth · 2016-08-01T13:23:53Z

Oh, you need this merged? Cool, I'll start up a batch.

(In the future, for high-pri or generally blocking/bitrotty things, please let me know that that's the case and I'll immediately initiate a breaking batch)

bors · 2016-08-12T11:37:58Z

☔ The latest upstream changes (presumably #35091) made this pull request unmergeable. Please resolve the merge conflicts.

pnkfelix · 2016-09-09T09:47:14Z

ping @Manishearth ; did you end up not starting up that batch?

pnkfelix · 2016-09-09T09:47:35Z

or maybe I should resolve the merge conflicts. I'll do that now. :)

Manishearth · 2016-09-09T09:50:33Z

The batch happened, but this PR wasn't in it, not sure why :/

bors · 2016-09-10T08:05:09Z

☔ The latest upstream changes (presumably #36332) made this pull request unmergeable. Please resolve the merge conflicts.

I am using `ThinAttributes` rather than a vector for attributes attached to generics, since I expect almost all lifetime and types parameters to not carry any attributes.

…s list.

…ached binding in generics.

pnkfelix · 2016-09-24T22:11:06Z

ping @Manishearth

Manishearth · 2016-09-25T06:41:00Z

It's in the list. Traveling right now, can't shepherd the rollup

First step for rust-lang#34761

…r=eddyb First step for rust-lang#34761

rust-highfive assigned sfackler Jul 11, 2016

pnkfelix mentioned this pull request Jul 11, 2016
#[may_dangle], a refined dropck escape hatch (tracking issue for RFC 1327) #34761
Open
7 tasks

rust-highfive assigned eddyb and unassigned sfackler Jul 11, 2016

aravind-pg reviewed Jul 11, 2016
View reviewed changes

Comment threadsrc/libsyntax/parse/parser.rs Outdated
aravind-pgJul 11, 2016
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: s/parsing/parse

Manishearth mentioned this pull request Jul 12, 2016
Batch up libsyntax breaking changes #33864
Merged

pnkfelix force-pushed the attrs-on-generic-formals branch from d554c5b to 2605680Compare July 22, 2016 15:33

dns2utf8 reviewed Jul 23, 2016
View reviewed changes

pnkfelix force-pushed the attrs-on-generic-formals branch from 2605680 to 115b74fCompare September 9, 2016 12:12

pnkfelix force-pushed the attrs-on-generic-formals branch from 115b74f to 3a9b7beCompare September 23, 2016 14:03

pnkfelix added 3 commits September 23, 2016 17:01

Add attribute support to generic lifetime and type parameters.
4c37ad6
I am using `ThinAttributes` rather than a vector for attributes attached to generics, since I expect almost all lifetime and types parameters to not carry any attributes.

Generic unit tests for attributes on lifetime/type formals in generic…
c242fc3
…s list.

Added tests and fixed corner case for trailing attributes with no att…
3a9b7be
…ached binding in generics.

Manishearth mentioned this pull request Sep 25, 2016
Tracking issue for libsyntax breaking changes #31645
Closed

Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 30, 2016
Rollup merge ofrust-lang#34764- pnkfelix:attrs-on-generic-formals, r=
173ebc3
First step for rust-lang#34761

Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 1, 2016
Rollup merge ofrust-lang#34764- pnkfelix:attrs-on-generic-formals, …
406fe7e
…r=eddyb First step for rust-lang#34761

bors merged commit 3a9b7be into rust-lang:masterOct 1, 2016

dtolnay mentioned this pull request Oct 10, 2016
Attributes on generic formals dtolnay/syn#35
Closed

petrochenkov mentioned this pull request Nov 12, 2016
Nightly regression: empty lifetime list in for<lifetime-list> doesn't parse anymore #37733
Closed

petrochenkov mentioned this pull request Mar 8, 2018
Tracking issue for attributes on generic parameters (generic_param_attrs) #48848
Closed

Uh oh!

Uh oh!

Conversation

pnkfelix commented Jul 11, 2016

Uh oh!

rust-highfive commented Jul 11, 2016

Uh oh!

eddyb commented Jul 11, 2016

Uh oh!

bors commented Jul 11, 2016

Uh oh!

durka commented Jul 11, 2016

Uh oh!

eddyb commented Jul 11, 2016

Uh oh!

aravind-pgJul 11, 2016

Choose a reason for hiding this comment

Uh oh!

bors commented Jul 20, 2016

Uh oh!

dns2utf8Jul 23, 2016

Choose a reason for hiding this comment

Uh oh!

pnkfelixSep 9, 2016

Choose a reason for hiding this comment

Uh oh!

dns2utf8 commented Jul 23, 2016

Uh oh!

eddyb commented Aug 1, 2016

Uh oh!

Manishearth commented Aug 1, 2016

Uh oh!

bors commented Aug 12, 2016

Uh oh!

pnkfelix commented Sep 9, 2016

Uh oh!

pnkfelix commented Sep 9, 2016

Uh oh!

Manishearth commented Sep 9, 2016

Uh oh!

bors commented Sep 10, 2016

Uh oh!

pnkfelix commented Sep 24, 2016

Uh oh!

Manishearth commented Sep 25, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants