Skip to content

Forbid type parameters and global paths in macro invocations - #34495

Merged
bors merged 2 commits into
rust-lang:masterfrom
jseyfried:only_ident_macro_invocations
Jun 30, 2016
Merged

Forbid type parameters and global paths in macro invocations#34495
bors merged 2 commits into
rust-lang:masterfrom
jseyfried:only_ident_macro_invocations

Conversation

@jseyfried

@jseyfriedjseyfried commented Jun 27, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#28558.
This is a [breaking-change]. For example, the following would break:

macro_rules! m {() => {()}}fnmain(){m::<T>!();// Type parameters are no longer allowed in macro invocations::m!();// Global paths are no longer allowed in macro invocations}

Any breakage can be fixed by removing the type parameters or the leading :: (respectively).

r? @eddyb

@jseyfriedjseyfried mentioned this pull request Jun 27, 2016
Closed
@jseyfried

jseyfried commented Jun 27, 2016

Copy link
Copy Markdown
ContributorAuthor

This probably needs a crater run.

@eddyb

eddyb commented Jun 27, 2016

Copy link
Copy Markdown
Contributor

Starting a crater run.

@eddyb

eddyb commented Jun 27, 2016

Copy link
Copy Markdown
Contributor

Crater report shows 0 regressions.

@eddyb

eddyb commented Jun 27, 2016

Copy link
Copy Markdown
Contributor

LGTM. cc @nrc@Manishearth

@Manishearth

Manishearth commented Jun 27, 2016

Copy link
Copy Markdown
Member

LGTM too. Since this doesn't actually change the grammar, it doesn't need to be part of the breaking batch either.

@jseyfried

jseyfried commented Jun 27, 2016

Copy link
Copy Markdown
ContributorAuthor

@eddyb r=you?

@eddyb

eddyb commented Jun 27, 2016

Copy link
Copy Markdown
Contributor

@jseyfried I'd like to hear back from another compiler/lang team member, like @nrc or @nikomatsakis (but niko is on vacation right now and might not respond for a while).

Or maybe we should require that, e.g. for language breaking changes, you notify @rust-lang/lang.

@jseyfried

jseyfried commented Jun 27, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@eddyb ok, makes sense -- no hurry.

We usually land clear bug fixes that cause no measurable breakage in practice without much discussion (perhaps we shouldn't).

@nrc

nrc commented Jun 27, 2016

Copy link
Copy Markdown
Member

LGTM

@bors: r=eddyb

@bors

bors commented Jun 27, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit b4611b1 has been approved by eddyb

@jseyfriedjseyfried mentioned this pull request Jun 29, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 29, 2016
@Manishearth
Rollup merge ofrust-lang#34495- jseyfried:only_ident_macro_invocati…
8886818
…ons, r=eddyb
Forbid type parameters and global paths in macro invocations
Fixesrust-lang#28558.
This is a [breaking-change]. For example, the following would break:
```rust
macro_rules! m { () => { () } }
fn main() {
m::<T>!(); // Type parameters are no longer allowed in macro invocations
::m!(); // Global paths are no longer allowed in macro invocations
}
```
Any breakage can be fixed by removing the type parameters or the leading `::` (respectively).
r? @eddyb
@ManishearthManishearth mentioned this pull request Jun 29, 2016
Merged
bors added a commit that referenced this pull request Jun 30, 2016
@bors
Auto merge of#34552- Manishearth:rollup, r=Manishearth
c2b56fb
Rollup of 11 pull requests
- Successful merges: #34355, #34446, #34459, #34460, #34467, #34495, #34497, #34499, #34513, #34536, #34542
- Failed merges:
@bors
bors merged commit b4611b1 into rust-lang:masterJun 30, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddybeddyb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Macro invocations allow type parameters in the path

5 participants

@jseyfried@eddyb@Manishearth@nrc@bors