Rollup of 5 pull requests by jseyfried · Pull Request #34541 · rust-lang/rust

jseyfried · 2016-06-29T00:56:37Z

Successful merges: rustdoc: Remove Derived Implementations title #34105, Added Default trait for Cow. #34305, Support CMake installations in paths containing spaces #34512, ~~Add error codes in libsyntax #34531,~~Fix pretty-printing of lifetime bound #34547

As far as I know whether a trait was derived or not does not change the public API so there is no need to include this information in the docs. This title currently just adds an extra divide in the list of trait implementations which I don't think needs to be there.

…hton rustdoc: Remove Derived Implementations title As far as I know whether a trait was derived or not does not change the public API so there is no need to include this information in the docs. This title currently just adds an extra divide in the list of trait implementations which I don't think needs to be there.

Added Default trait for Cow. Adds a default implementation for Cow. Which is the Owned's default.

rust-highfive · 2016-06-29T00:56:48Z

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

jseyfried · 2016-06-29T00:58:14Z

@bors force r+

bors · 2016-06-29T00:58:15Z

📌 Commit b4f7937 has been approved by jseyfried

jseyfried · 2016-06-29T00:59:36Z

@bors force p=2

bors · 2016-06-29T01:01:03Z

⌛ Testing commit b4f7937 with merge 3028db8...

bors · 2016-06-29T01:06:09Z

⌛ Testing commit b4f7937 with merge 74bce92...

bors · 2016-06-29T04:26:56Z

💔 Test failed - auto-linux-64-x-android-t

jseyfried · 2016-06-29T04:29:02Z

@bors retry force clean

bors · 2016-06-29T04:30:19Z

⌛ Testing commit b4f7937 with merge 12da950...

jseyfried · 2016-06-29T04:33:54Z

cc @alexcrichton -- android timed out

bors · 2016-06-29T06:14:01Z

💔 Test failed - auto-linux-64-x-android-t

jseyfried · 2016-06-29T11:47:53Z

@bors retry

bors · 2016-06-29T12:42:09Z

⚡ Previous build results for auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-msvc-64-cargotest are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-win-gnu-32-opt, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild...

bors · 2016-06-29T14:27:05Z

💔 Test failed - auto-linux-64-x-android-t

alexcrichton · 2016-06-29T16:20:21Z

Yeah looks like the android builder is having a lot of trouble right now, I'm gonna try to watch it closely to see if I can diagnose what's going on. I don't think it's related to changes in this PR, though.

@bors: retry

bors · 2016-06-29T17:59:15Z

💣 Failed to start rebuilding: 301 Moved Permanently

bors · 2016-06-29T17:59:18Z

⌛ Testing commit b4f7937 with merge 36309e1...

jseyfried · 2016-06-29T18:33:20Z

@alexcrichton thanks, yeah android was failing the same way on several unrelated PRs.

bors · 2016-06-29T19:40:04Z

💔 Test failed - auto-linux-64-x-android-t

…=alexcrichton Support CMake installations in paths containing spaces This solves rust-lang#34490

jseyfried · 2016-06-30T03:51:33Z

@bors r+

bors · 2016-06-30T03:51:34Z

📌 Commit e59adb9 has been approved by jseyfried

bors · 2016-06-30T04:42:12Z

⌛ Testing commit e59adb9 with merge 50f1175...

bors · 2016-06-30T06:56:06Z

💔 Test failed - auto-win-gnu-64-opt

Fix pretty-printing of lifetime bound Fixrust-lang#34527.

jseyfried · 2016-06-30T07:41:36Z

@bors r+

bors · 2016-06-30T07:41:38Z

📌 Commit a8751e0 has been approved by jseyfried

bors · 2016-06-30T08:49:46Z

⌛ Testing commit a8751e0 with merge 85c31af...

Rollup of 5 pull requests - Successful merges: #34105, #34305, #34512, ~~#34531,~~ #34547

bors · 2016-06-30T10:49:44Z

💔 Test failed - auto-win-msvc-64-opt-rustbuild

jseyfried · 2016-06-30T10:59:41Z

@bors retry

bors · 2016-06-30T12:53:18Z

⚡ Previous build results for auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-cross-opt, auto-mac-32-opt, auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-msvc-64-cargotest are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-musl-64-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-win-gnu-32-opt, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild...

bors · 2016-06-30T14:48:02Z

💔 Test failed - auto-win-msvc-64-opt-rustbuild

alexcrichton · 2016-06-30T16:04:12Z

@bors: retry

rustbuild: Clean out tmp directory on make clean #34577

On Thu, Jun 30, 2016 at 7:48 AM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/1610
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34541 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95IpetbqwFnlKkwGiQRos4JF9JfpNks5qQ9clgaJpZM4JArNY
.

bors · 2016-06-30T19:18:57Z

⚡ Previous build results for auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-opt-rustbuild, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-msvc-64-cargotest are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-x-android-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-win-gnu-32-opt, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild...

bors · 2016-06-30T21:32:24Z

💔 Test failed - auto-mac-64-opt-rustbuild

arielb1 · 2016-06-30T21:38:05Z

---- Rust_Compiler_Error_Index_537 stdout ----
<anon>:1:1: 1:15 error: export_name attribute has invalid format
<anon>:1 #[export_name]
^~~~~~~~~~~~~~
<anon>:1:1: 1:15 help: use #[export_name="*"]
thread 'Rust_Compiler_Error_Index_537' panicked at 'Some expected error codes were not found: ["E0533"]', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/librustdoc/test.rs:298

alexcrichton · 2016-06-30T22:30:03Z

@bors: retry

rustbuild: Clean out tmp directory on make clean #34577 (comment)

On Thu, Jun 30, 2016 at 2:38 PM, arielb1 notifications@github.com wrote:

---- Rust_Compiler_Error_Index_537 stdout ----
:1:1: 1:15 error: export_name attribute has invalid format
:1 #[export_name]
^~~~~~~~~~~~~~
:1:1: 1:15 help: use #[export_name="*"]
thread 'Rust_Compiler_Error_Index_537' panicked at 'Some expected error codes were not found: ["E0533"]', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/librustdoc/test.rs:298
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34541 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95H4i8SwzayFFRlsrGroPPGUNj6wZks5qRDdAgaJpZM4JArNY
.

bors · 2016-06-30T22:31:01Z

⚡ Previous build results for auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt-rustbuild are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-win-gnu-32-opt, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir...

bors · 2016-06-30T22:33:08Z

⛄ The build was interrupted to prioritize another pull request.

bors · 2016-07-01T00:18:08Z

⚡ Previous build results for auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt-rustbuild are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-win-gnu-32-opt, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir...

bors · 2016-07-01T03:07:54Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

ollie27and others added 5 commits June 5, 2016 23:50

Added Default trait for Cow
703d7b5

Support CMake installations in paths containing spaces
37f0f67

Rollup merge ofrust-lang#34305- Aaronepower:master, r=alexcrichton
a77a179
Added Default trait for Cow. Adds a default implementation for Cow. Which is the Owned's default.

rust-highfive assigned Aatch Jun 29, 2016

Fix pretty-printing of lifetime bound
3c29fc5

Rollup merge ofrust-lang#34512- CensoredUsername:configure-fixes, r…
bd7a363
…=alexcrichton Support CMake installations in paths containing spaces This solves rust-lang#34490

jseyfried force-pushed the rollup branch from b4f7937 to e59adb9Compare June 30, 2016 03:49

Rollup merge ofrust-lang#34547- sanxiyn:pretty-lifetime, r=pnkfelix
a8751e0
Fix pretty-printing of lifetime bound Fixrust-lang#34527.

jseyfried force-pushed the rollup branch from e59adb9 to a8751e0Compare June 30, 2016 07:40

bors added a commit that referenced this pull request Jun 30, 2016
Auto merge of#34541- jseyfried:rollup, r=jseyfried
85c31af
Rollup of 5 pull requests - Successful merges: #34105, #34305, #34512, ~~#34531,~~ #34547

bors mentioned this pull request Jul 1, 2016
Added Default trait for Cow. #34305
Merged

bors merged commit a8751e0 into rust-lang:masterJul 1, 2016

bors mentioned this pull request Jul 1, 2016
Fix invalid trait generation #33935
Closed

Centril added the rollup A PR which is a rollup label Oct 2, 2019

Uh oh!

Uh oh!

Conversation

jseyfried commented Jun 29, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jun 29, 2016

Uh oh!

jseyfried commented Jun 29, 2016

Uh oh!

bors commented Jun 29, 2016

Uh oh!

jseyfried commented Jun 29, 2016

Uh oh!

bors commented Jun 29, 2016

Uh oh!

bors commented Jun 29, 2016

Uh oh!

bors commented Jun 29, 2016

Uh oh!

jseyfried commented Jun 29, 2016

Uh oh!

bors commented Jun 29, 2016

Uh oh!

jseyfried commented Jun 29, 2016

Uh oh!

bors commented Jun 29, 2016

Uh oh!

jseyfried commented Jun 29, 2016

Uh oh!

bors commented Jun 29, 2016

Uh oh!

bors commented Jun 29, 2016

Uh oh!

alexcrichton commented Jun 29, 2016

Uh oh!

bors commented Jun 29, 2016

Uh oh!

bors commented Jun 29, 2016

Uh oh!

jseyfried commented Jun 29, 2016

Uh oh!

bors commented Jun 29, 2016

Uh oh!

jseyfried commented Jun 30, 2016

Uh oh!

bors commented Jun 30, 2016

Uh oh!

bors commented Jun 30, 2016

Uh oh!

bors commented Jun 30, 2016

Uh oh!

jseyfried commented Jun 30, 2016

Uh oh!

bors commented Jun 30, 2016

Uh oh!

bors commented Jun 30, 2016

Uh oh!

bors commented Jun 30, 2016

Uh oh!

jseyfried commented Jun 30, 2016

Uh oh!

bors commented Jun 30, 2016

Uh oh!

bors commented Jun 30, 2016

Uh oh!

alexcrichton commented Jun 30, 2016

Uh oh!

bors commented Jun 30, 2016

Uh oh!

bors commented Jun 30, 2016

Uh oh!

arielb1 commented Jun 30, 2016

Uh oh!

alexcrichton commented Jun 30, 2016

Uh oh!

bors commented Jun 30, 2016

Uh oh!

bors commented Jun 30, 2016

Uh oh!

jseyfried commented Jun 29, 2016•
edited
Loading