Skip to content

rustbuild: Clean out tmp directory on make clean - #34577

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:clean-more-yet-again
Jul 1, 2016
Merged

rustbuild: Clean out tmp directory on make clean#34577
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:clean-more-yet-again

Conversation

@alexcrichton

@alexcrichtonalexcrichton commented Jun 30, 2016

Copy link
Copy Markdown
Member

Right now we generate error index information into this directory, but it's
never cleaned out. This means that if a build bounces because of something in
this directory it'll continue to cause all future builds to fail because the
relevant files are never removed.

@rust-highfive

rust-highfive commented Jun 30, 2016

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

alexcrichton commented Jun 30, 2016

Copy link
Copy Markdown
MemberAuthor

@bors: r+ 98adb2f p=10

Need to un-stick bors

cc @brson though, if you object I can always revert!

This was referenced Jun 30, 2016
Merged
Merged
Merged
bors added a commit that referenced this pull request Jun 30, 2016
@bors
Auto merge of#34577- alexcrichton:clean-more-yet-again, r=alexcrichton
78812ca
rustbuild: Clean out tmp directory on `make clean`
Right now we generate error index information into this directory, but it's
never cleaned out. This means that if a build *bounces* because of something in
this directory it'll continue to cause all future builds to fail because the
relevant files are never removed.
@bors

bors commented Jun 30, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 98adb2f with merge 78812ca...

@alexcrichtonalexcrichton mentioned this pull request Jun 30, 2016
Merged
@bors

bors commented Jun 30, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-opt-rustbuild

@alexcrichton
rustbuild: Clean out tmp directory on make clean
1e48a72
Right now we generate error index information into this directory, but it's
never cleaned out. This means that if a build *bounces* because of something in
this directory it'll continue to cause all future builds to fail because the
relevant files are never removed.
@alexcrichton

alexcrichton commented Jun 30, 2016

Copy link
Copy Markdown
MemberAuthor

Ok the fact that both tmp/ and build/tmp/ exists is a bug that we need to fix...

@alexcrichton

alexcrichton commented Jun 30, 2016

Copy link
Copy Markdown
MemberAuthor

@bors: r=brson

@bors

bors commented Jun 30, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 1e48a72 has been approved by brson

@alexcrichton

alexcrichton commented Jun 30, 2016

Copy link
Copy Markdown
MemberAuthor

@bors: force

@bors

bors commented Jun 30, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1e48a72 with merge d15ac78...

@bors

bors commented Jun 30, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-cross-opt

@alexcrichton

alexcrichton commented Jun 30, 2016

Copy link
Copy Markdown
MemberAuthor

@bors: retry

@alexcrichton

alexcrichton commented Jun 30, 2016

Copy link
Copy Markdown
MemberAuthor

@bors: force

@bors

bors commented Jun 30, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1e48a72 with merge 2f7b87f...

@bors

bors commented Jul 1, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-x-android-t

@alexcrichton

alexcrichton commented Jul 1, 2016

Copy link
Copy Markdown
MemberAuthor

@bors: retry

On Thu, Jun 30, 2016 at 5:18 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-x-android-t
https://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/9616

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34577 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95KyUhW87aJyU3fmXOP63G4ZkMxiPks5qRFy_gaJpZM4JCUYo
.

@bors

bors commented Jul 1, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1e48a72 with merge 375fa6e...

bors added a commit that referenced this pull request Jul 1, 2016
@bors
Auto merge of#34577- alexcrichton:clean-more-yet-again, r=brson
375fa6e
rustbuild: Clean out tmp directory on `make clean`
Right now we generate error index information into this directory, but it's
never cleaned out. This means that if a build *bounces* because of something in
this directory it'll continue to cause all future builds to fail because the
relevant files are never removed.
@bors

bors commented Jul 1, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

@bors
bors merged commit 1e48a72 into rust-lang:masterJul 1, 2016
@retep998retep998 mentioned this pull request Jul 1, 2016
Closed
@alexcrichton
alexcrichton deleted the clean-more-yet-again branch July 7, 2016 16:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturonaturon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexcrichton@rust-highfive@bors@aturon