Uh oh!
There was an error while loading. Please reload this page.
mk: Don't consider LLVM done until it's done - #34563
Conversation
rust-highfive
commented
Jun 29, 2016
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
brson
commented
Jun 29, 2016
@bors r+ p=1 |
bors
commented
Jun 29, 2016
📌 Commit f94b2f2 has been approved by |
bors
commented
Jun 30, 2016
⌛ Testing commit f94b2f2 with merge 98f7ce9... |
bors
commented
Jun 30, 2016
💔 Test failed - auto-linux-64-opt-mir |
Currently if an LLVM build is interrupted *after* it creates the llvm-config binary but before it's done it puts us in an inconsistent state where we think LLVM is compiled but it's not actually. This tweaks our logic to only consider LLVM done building once it's actually done building. This should hopefully alleviate problems on the bots where if we interrupt at the wrong time it doesn't corrupt the build directory.
alexcrichton
commented
Jun 30, 2016
@bors: r=brson |
bors
commented
Jun 30, 2016
📌 Commit 9e2bd92 has been approved by |
bors
commented
Jun 30, 2016
⌛ Testing commit 9e2bd92 with merge 949f893... |
bors
commented
Jun 30, 2016
⛄ The build was interrupted to prioritize another pull request. |
bors
commented
Jul 1, 2016
mk: Don't consider LLVM done until it's done Currently if an LLVM build is interrupted *after* it creates the llvm-config binary but before it's done it puts us in an inconsistent state where we think LLVM is compiled but it's not actually. This tweaks our logic to only consider LLVM done building once it's actually done building. This should hopefully alleviate problems on the bots where if we interrupt at the wrong time it doesn't corrupt the build directory.
bors
commented
Jul 1, 2016
💔 Test failed - auto-linux-64-x-android-t |
alexcrichton
commented
Jul 1, 2016
alexcrichton
commented
Jul 1, 2016
@bors: retry On Fri, Jul 1, 2016 at 1:47 AM, bors notifications@github.com wrote:
|
Currently if an LLVM build is interrupted after it creates the llvm-config
binary but before it's done it puts us in an inconsistent state where we think
LLVM is compiled but it's not actually. This tweaks our logic to only consider
LLVM done building once it's actually done building.
This should hopefully alleviate problems on the bots where if we interrupt at
the wrong time it doesn't corrupt the build directory.