Skip to content

Various std::process doc improvements. - #34737

Merged
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:libstd-process-child
Jul 12, 2016
Merged

Various std::process doc improvements.#34737
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:libstd-process-child

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Jul 9, 2016

Copy link
Copy Markdown
Contributor

No description provided.

GuillaumeGomez
GuillaumeGomez reviewed Jul 9, 2016
View reviewed changes
Comment threadsrc/libstd/process.rs Outdated

@GuillaumeGomezGuillaumeGomezJul 9, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an english native but I'm pretty sure you don't write "process's" but "process'". But maybe I'm wrong so please correct me if this is the case.

@frewsxcvfrewsxcvJul 9, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally say process's, but I might be wrong and English is weird.

@GuillaumeGomezGuillaumeGomezJul 9, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. It doesn't help. 😆

@apasel422apasel422Jul 9, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

process's is correct.

@GuillaumeGomezGuillaumeGomezJul 9, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then my bad!

@GuillaumeGomez

GuillaumeGomez commented Jul 9, 2016

Copy link
Copy Markdown
Member

For such small changes, I think one commit is more than enough.

@frewsxcv
frewsxcvforce-pushed the libstd-process-child branch from 8abf789 to d0b8114CompareJuly 10, 2016 13:58
@frewsxcv

frewsxcv commented Jul 10, 2016

Copy link
Copy Markdown
ContributorAuthor

Squashed.

@GuillaumeGomez

GuillaumeGomez commented Jul 10, 2016

Copy link
Copy Markdown
Member

@bors: r+ rollup

@bors

bors commented Jul 10, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit d0b8114 has been approved by GuillaumeGomez

@bors

bors commented Jul 10, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d0b8114 with merge 17964c8...

@bors

bors commented Jul 10, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-opt

@frewsxcv

frewsxcv commented Jul 10, 2016

Copy link
Copy Markdown
ContributorAuthor

Error looks unrelated?

@GuillaumeGomez

GuillaumeGomez commented Jul 10, 2016

Copy link
Copy Markdown
Member

Strange...

@bors: retry

@bors

bors commented Jul 10, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d0b8114 with merge e6576bc...

@bors

bors commented Jul 11, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@frewsxcv

frewsxcv commented Jul 11, 2016

Copy link
Copy Markdown
ContributorAuthor
Linkcheck stage2 (i686-pc-windows-gnu)
std\process\struct.Child.html:95: broken link - std\process\or other functions that wrap around it
thread 'main' panicked at 'found some broken links', C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\tools\linkchecker\main.rs:54
note: Run with `RUST_BACKTRACE=1` for a backtrace.

If anyone has any idea which of my links is broken, let me know. I don't have enough time right now to look into it, but it's not obvious to me which is broken.

@steveklabnik

steveklabnik commented Jul 11, 2016

Copy link
Copy Markdown
Contributor

It's not clear to me either :/

@frewsxcvfrewsxcv mentioned this pull request Jul 11, 2016
Closed
retep998
retep998 reviewed Jul 11, 2016
View reviewed changes
Comment threadsrc/libstd/process.rs Outdated

@retep998retep998Jul 11, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is this link which is broken.

@frewsxcvfrewsxcvJul 11, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this link broken?

@frewsxcvfrewsxcvJul 11, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it think (or other functions that wrap around it) is the href? Is there a way around this if so?

@alexcrichtonalexcrichtonJul 11, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's how markdown is interpreting it, you may be able to escape it via \( I believe

@frewsxcvfrewsxcvJul 11, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just force pushed. Changed it to:

[`wait`][`wait`]

@frewsxcv
std::process doc improvements.
97d96bd
* Link to `process::Command` from `process::Child`.
* Move out inline Markdown link in doc comment.
* Link to `process::Child::wait` from `process::Child`.
* Link to `process::Child` from `process::ChildStdin`.
* Link to `process::Child` from `process::ChildStdout`.
* Link to `process::Child` from `process::ChildStderr`.
@frewsxcv
frewsxcvforce-pushed the libstd-process-child branch from d0b8114 to 97d96bdCompareJuly 11, 2016 16:08
@GuillaumeGomez

GuillaumeGomez commented Jul 11, 2016

Copy link
Copy Markdown
Member

@bors: r+ rollup

@bors

bors commented Jul 11, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 97d96bd has been approved by GuillaumeGomez

@GuillaumeGomezGuillaumeGomez mentioned this pull request Jul 12, 2016
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 12, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#34737- frewsxcv:libstd-process-child, r=Gu…
a94e4c0
…illaumeGomez
Various `std::process` doc improvements.
None
bors added a commit that referenced this pull request Jul 12, 2016
@bors
Auto merge of#34778- GuillaumeGomez:rollup, r=GuillaumeGomez
31e9ed5
Rollup of 7 pull requests
- Successful merges: #34736, #34737, #34740, #34742, #34749, #34750, #34770
- Failed merges: #33951
@bors
bors merged commit 97d96bd into rust-lang:masterJul 12, 2016
@frewsxcv
frewsxcv deleted the libstd-process-child branch July 12, 2016 13:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@frewsxcv@GuillaumeGomez@bors@steveklabnik@alexcrichton@retep998@apasel422