run rustfmt on librustc_passes folder by srinivasreddy · Pull Request #33951 · rust-lang/rust

srinivasreddy · 2016-05-29T15:40:13Z

No description provided.

rust-highfive · 2016-05-29T15:40:25Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

nagisa · 2016-05-29T16:51:44Z

Becomes weirdly misaligned.

I didn't find an existing rustfmt issue, so I filed rust-lang/rustfmt#1026 -- @nagisa, is that what you meant?

nikomatsakis · 2016-05-31T20:07:39Z

I'd be happy to r+ but for this tidy failure:

https://travis-ci.org/rust-lang/rust/builds/133743527#L1234

seems like a bug in rustfmt?

srinivasreddy · 2016-06-07T18:33:45Z

@nikomatsakis I roll up please. I removed that line manually.

nikomatsakis · 2016-06-08T20:02:57Z

@srinivasreddy did you file some sort of bug in rustfmt repo?

srinivasreddy · 2016-06-09T15:15:51Z

nope.AFAIK, Not required. rustfmt does not panic when it crosses 100 chars limit in a line and goes on formatting, And it just gives you sorry message on console. I guess it is an expected behaviour. Let's confirm with what @nrc says.

nikomatsakis · 2016-06-27T16:02:34Z

@srinivasreddy seems like this bug rust-lang/rustfmt#1080 fits the bill, sort of.

nikomatsakis · 2016-06-27T16:03:23Z

@bors r+ rollup

bors · 2016-06-27T16:03:24Z

📌 Commit faa039f has been approved by nikomatsakis

… r=nikomatsakis run rustfmt on librustc_passes folder

bors · 2016-06-28T04:49:30Z

☔ The latest upstream changes (presumably #34424) made this pull request unmergeable. Please resolve the merge conflicts.

Rollup of 13 pull requests - Successful merges: #34080, #34287, #34328, #34406, #34415, #34442, #34462, #34471, #34475, #34479, #34517, #34518, #34524 - Failed merges: #33951

bors · 2016-07-01T13:30:59Z

🔒 Merge conflict

Rollup of 15 pull requests - Successful merges: #33250, #33265, #34277, #34327, #34521, #34558, #34615, #34619, #34621, #34625, #34626, #34636, #34664, #34667, #34685 - Failed merges: #33951

Rollup of 7 pull requests - Successful merges: #34736, #34737, #34740, #34742, #34749, #34750, #34770 - Failed merges: #33951

Rollup of 7 pull requests - Successful merges: #34456, #34733, #34777, #34794, #34799, #34804, #34818 - Failed merges: #33951

jseyfried · 2016-07-22T17:13:17Z

Strange indent.

All of these are due to the same reason and all should be fixed up manually.

bors · 2016-07-28T00:39:05Z

☔ The latest upstream changes (presumably #34907) made this pull request unmergeable. Please resolve the merge conflicts.

nikomatsakis · 2016-07-29T12:59:47Z

Just in general my feeling is that if there is "suboptimal" formatting we should certainly make issues about it and discuss it as rustfmt guidelines get hammered out, but in general we want to adopt automated formatting just because it everyone's life easier -- even if there are some corner cases where hand-formatting might improve things. (Most of the examples raised here I personally could go either way, I admit.)

nikomatsakis · 2016-08-03T23:01:15Z

@srinivasreddy want to rebase this?

srinivasreddy · 2016-08-04T04:48:28Z

@nikomatsakis Done.

bors · 2016-08-04T08:57:02Z

☔ The latest upstream changes (presumably #35015) made this pull request unmergeable. Please resolve the merge conflicts.

srinivasreddy · 2016-08-05T01:30:01Z

@nikomatsakis Done.

nikomatsakis · 2016-08-05T22:28:45Z

@bors r+

bors · 2016-08-05T22:28:46Z

📌 Commit a6c9404 has been approved by nikomatsakis

bors · 2016-08-06T09:27:30Z

⌛ Testing commit a6c9404 with merge 1fd8b88...

…akis run rustfmt on librustc_passes folder

… r=nikomatsakis run rustfmt on librustc_passes folder

bors · 2016-08-06T12:02:15Z

⛄ The build was interrupted to prioritize another pull request.

Rollup of 21 pull requests - Successful merges: #33951, #34916, #35287, #35288, #35351, #35353, #35356, #35362, #35363, #35364, #35366, #35368, #35370, #35372, #35373, #35374, #35375, #35376, #35380, #35393, #35394 - Failed merges: #35331, #35395

bors · 2016-08-06T14:38:20Z

⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt-no-mir, auto-win-msvc-64-opt-rustbuild are reusable. Rebuilding only auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-mac-32-opt, auto-win-gnu-32-opt, auto-win-msvc-64-opt...

bors · 2016-08-06T14:42:19Z

⛄ The build was interrupted to prioritize another pull request.

rust-highfive assigned nikomatsakis May 29, 2016

nagisa reviewed May 29, 2016
View reviewed changes

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 27, 2016
Rollup merge ofrust-lang#33951- srinivasreddy:librust_pass_rustfmt,…
9f6e900
… r=nikomatsakis run rustfmt on librustc_passes folder

steveklabnik mentioned this pull request Jun 27, 2016
Rollup of 11 pull requests #34508
Closed

GuillaumeGomez mentioned this pull request Jun 28, 2016
Rollup of 13 pull requests #34525
Merged

This was referenced Jul 5, 2016
Rollup of 13 pull requests #34670
Closed
Rollup of 12 pull requests #34671
Closed

steveklabnik mentioned this pull request Jul 6, 2016
Rollup of 15 pull requests #34695
Merged

GuillaumeGomez mentioned this pull request Jul 12, 2016
Rollup of 7 pull requests #34778
Merged

bors added a commit that referenced this pull request Jul 12, 2016
Auto merge of#34778- GuillaumeGomez:rollup, r=GuillaumeGomez
31e9ed5
Rollup of 7 pull requests - Successful merges: #34736, #34737, #34740, #34742, #34749, #34750, #34770 - Failed merges: #33951

GuillaumeGomez mentioned this pull request Jul 14, 2016
Rollup of 7 pull requests #34819
Merged

bors added a commit that referenced this pull request Jul 15, 2016
Auto merge of#34819- GuillaumeGomez:rollup, r=GuillaumeGomez
3cc3ad1
Rollup of 7 pull requests - Successful merges: #34456, #34733, #34777, #34794, #34799, #34804, #34818 - Failed merges: #33951

GuillaumeGomez mentioned this pull request Jul 16, 2016
Rollup of 7 pull requests #34852
Merged

jseyfried reviewed Jul 22, 2016
View reviewed changes

run rustfmt on librustc_passes folder
a6c9404

eddyb mentioned this pull request Aug 6, 2016
Rollup of 21 pull requests #35407
Merged

bors added a commit that referenced this pull request Aug 6, 2016
Auto merge of#33951- srinivasreddy:librust_pass_rustfmt, r=nikomats…
1fd8b88
…akis run rustfmt on librustc_passes folder

eddyb added a commit to eddyb/rust that referenced this pull request Aug 6, 2016
Rollup merge ofrust-lang#33951- srinivasreddy:librust_pass_rustfmt,…
8e04264
… r=nikomatsakis run rustfmt on librustc_passes folder

bors merged commit a6c9404 into rust-lang:masterAug 6, 2016

srinivasreddy deleted the librust_pass_rustfmt branch August 7, 2016 04:35

Uh oh!

Uh oh!

Conversation

srinivasreddy commented May 29, 2016

Uh oh!

rust-highfive commented May 29, 2016

Uh oh!

nagisaMay 29, 2016

Choose a reason for hiding this comment

Uh oh!

nikomatsakisMay 31, 2016

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented May 31, 2016

Uh oh!

srinivasreddy commented Jun 7, 2016

Uh oh!

nikomatsakis commented Jun 8, 2016

Uh oh!

srinivasreddy commented Jun 9, 2016

Uh oh!

nikomatsakis commented Jun 27, 2016

Uh oh!

nikomatsakis commented Jun 27, 2016

Uh oh!

bors commented Jun 27, 2016

Uh oh!

bors commented Jun 28, 2016

Uh oh!

bors commented Jul 1, 2016

Uh oh!

jseyfriedJul 22, 2016

Choose a reason for hiding this comment

Uh oh!

nrcJul 25, 2016

Choose a reason for hiding this comment

Uh oh!

bors commented Jul 28, 2016

Uh oh!

nikomatsakis commented Jul 29, 2016

Uh oh!

nikomatsakis commented Aug 3, 2016

Uh oh!

srinivasreddy commented Aug 4, 2016

Uh oh!

bors commented Aug 4, 2016

Uh oh!

srinivasreddy commented Aug 5, 2016

Uh oh!

nikomatsakis commented Aug 5, 2016

Uh oh!

bors commented Aug 5, 2016

Uh oh!

bors commented Aug 6, 2016

Uh oh!

bors commented Aug 6, 2016

Uh oh!

bors commented Aug 6, 2016

Uh oh!

bors commented Aug 6, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants