Skip to content

Updated E0071 to new format. - #35285

Merged
bors merged 1 commit into
rust-lang:masterfrom
razielgn:updated-e0071-to-new-format
Aug 5, 2016
Merged

Updated E0071 to new format.#35285
bors merged 1 commit into
rust-lang:masterfrom
razielgn:updated-e0071-to-new-format

Conversation

@razielgn

@razielgnrazielgn commented Aug 4, 2016

Copy link
Copy Markdown
Contributor

Bonus: the span underlines only the name of the thing that's not a struct rather than the whole expression.

Part of #35233.
Fixes#35220.

r? @jonathandturner

@rust-highfive

rust-highfive commented Aug 4, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt

sophiajt commented Aug 4, 2016

Copy link
Copy Markdown
Contributor

Can you also update src/test/compile-fail/trait-as-struct-constructor.rs to use the new label? With that, I'd be happy to approve.

@razielgn
Updated E0071 to new format.
7c58b26
The span underlines only the name of the thing that's not a struct rather
than the whole expression.
@razielgn

razielgn commented Aug 4, 2016

Copy link
Copy Markdown
ContributorAuthor

@jonathandturner sorry, I forgot it. 😄 Updated!

@razielgn
razielgnforce-pushed the updated-e0071-to-new-format branch from 4b4836e to 7c58b26CompareAugust 4, 2016 15:27
@sophiajt

sophiajt commented Aug 4, 2016

Copy link
Copy Markdown
Contributor

Great, thanks!

@bors r+ rollup

@bors

bors commented Aug 4, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 7c58b26 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 4, 2016
Jonathan Turner
Rollup merge ofrust-lang#35285- razielgn:updated-e0071-to-new-forma…
bc531c8
…t, r=jonathandturner
Updated E0071 to new format.
Bonus: the span underlines only the name of the thing that's not a struct rather than the whole expression.
Part of rust-lang#35233.
Fixesrust-lang#35220.
r? @jonathandturner
@sophiajtsophiajt mentioned this pull request Aug 4, 2016
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 4, 2016
@steveklabnik
Rollup merge ofrust-lang#35285- razielgn:updated-e0071-to-new-forma…
e70b1ba
…t, r=jonathandturner
Updated E0071 to new format.
Bonus: the span underlines only the name of the thing that's not a struct rather than the whole expression.
Part of rust-lang#35233.
Fixesrust-lang#35220.
r? @jonathandturner
@steveklabniksteveklabnik mentioned this pull request Aug 4, 2016
Closed
@GuillaumeGomezGuillaumeGomez mentioned this pull request Aug 4, 2016
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 5, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#35285- razielgn:updated-e0071-to-new-forma…
58d5900
…t, r=jonathandturner
Updated E0071 to new format.
Bonus: the span underlines only the name of the thing that's not a struct rather than the whole expression.
Part of rust-lang#35233.
Fixesrust-lang#35220.
r? @jonathandturner
bors added a commit that referenced this pull request Aug 5, 2016
@bors
Auto merge of#35332- GuillaumeGomez:rollup, r=GuillaumeGomez
5101d6e
Rollup of 30 pull requests
- Successful merges: #34319, #34894, #35041, #35042, #35076, #35109, #35137, #35175, #35181, #35182, #35189, #35239, #35264, #35266, #35281, #35285, #35289, #35291, #35294, #35296, #35297, #35298, #35299, #35318, #35319, #35324, #35326, #35328, #35331
- Failed merges:
@GuillaumeGomezGuillaumeGomez mentioned this pull request Aug 5, 2016
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 5, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#35285- razielgn:updated-e0071-to-new-forma…
da981cf
…t, r=jonathandturner
Updated E0071 to new format.
Bonus: the span underlines only the name of the thing that's not a struct rather than the whole expression.
Part of rust-lang#35233.
Fixesrust-lang#35220.
r? @jonathandturner
bors added a commit that referenced this pull request Aug 5, 2016
@bors
Auto merge of#35365- GuillaumeGomez:rollup, r=GuillaumeGomez
b30eff7
Rollup of 30 pull requests
- Successful merges: #34319, #35041, #35042, #35076, #35109, #35137, #35175, #35181, #35182, #35189, #35239, #35264, #35266, #35281, #35285, #35289, #35291, #35294, #35296, #35297, #35298, #35299, #35318, #35319, #35324, #35326, #35328, #35333, #35359, #35362
- Failed merges:
@bors
bors merged commit 7c58b26 into rust-lang:masterAug 5, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sophiajtsophiajt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@razielgn@rust-highfive@sophiajt@bors