Updated error message E0252 by medzin · Pull Request #35362 · rust-lang/rust

medzin · 2016-08-05T11:17:41Z

Fixes#35306 as part of #35233.

rust-highfive · 2016-08-05T11:17:56Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez · 2016-08-05T11:19:56Z

Thanks!

@bors: r+ rollup

bors · 2016-08-05T11:19:57Z

📌 Commit ef23c94 has been approved by GuillaumeGomez

GuillaumeGomez · 2016-08-05T13:49:38Z

@bors: rollup-

Rollup of 30 pull requests - Successful merges: #34319, #35041, #35042, #35076, #35109, #35137, #35175, #35181, #35182, #35189, #35239, #35264, #35266, #35281, #35285, #35289, #35291, #35294, #35296, #35297, #35298, #35299, #35318, #35319, #35324, #35326, #35328, #35333, #35359, #35362 - Failed merges:

sophiajt · 2016-08-05T15:36:27Z

Thanks for the PR!

Looks like there are other tests that need to be updated. If you run git grep E0252 after updating, you should see the other test.

TimNN · 2016-08-05T16:58:18Z

@jonathandturner sadly the failing tests don't include the error code.

@medzin the tests that fail are compile-fail/issue-26886.rs and compile-fail/use-mod.rs as far as I can tell, see #35365 (comment).

bors · 2016-08-05T17:17:20Z

⌛ Testing commit ef23c94 with merge 073cbb6...

@GuillaumeGomez

Updated error message E0252 Fixes#35306 as part of #35233. r? @GuillaumeGomez

sophiajt · 2016-08-05T17:20:00Z

You should be able run it against all the compile-fail tests using:

python src/bootstrap/bootstrap.py --stage 1 --step check-cfail

bors · 2016-08-05T18:29:48Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

sophiajt · 2016-08-05T22:06:28Z

Looks good!

@bors r+ rollup

bors · 2016-08-05T22:06:29Z

📌 Commit 3a255d8 has been approved by jonathandturner

GuillaumeGomez · 2016-08-06T11:13:13Z

@bors: r-

@medzin: Please squash your last commit.

medzin · 2016-08-06T11:32:21Z

@GuillaumeGomez done

Rollup of 21 pull requests - Successful merges: #33951, #34916, #35287, #35288, #35351, #35353, #35356, #35362, #35363, #35364, #35366, #35368, #35370, #35372, #35373, #35374, #35375, #35376, #35380, #35393, #35394 - Failed merges: #35331, #35395

GuillaumeGomez · 2016-08-06T14:06:51Z

Thanks!

@bors: r+ rollup

bors · 2016-08-06T14:06:52Z

📌 Commit f4dd1f9 has been approved by GuillaumeGomez

bors · 2016-08-06T16:57:32Z

⌛ Testing commit f4dd1f9 with merge 1518459...

@GuillaumeGomez

Updated error message E0252 Fixes#35306 as part of #35233. r? @GuillaumeGomez

bors · 2016-08-06T19:29:27Z

💔 Test failed - auto-linux-64-debug-opt

sophiajt · 2016-08-06T19:43:09Z

@bors retry

@GuillaumeGomez

Updated error message E0252 Fixesrust-lang#35306 as part of rust-lang#35233. r? @GuillaumeGomez

Rollup of 9 pull requests - Successful merges: #35362, #35393, #35394, #35402, #35410, #35411, #35413, #35419, #35421 - Failed merges: #35395, #35415

@GuillaumeGomez

Updated error message E0252 Fixesrust-lang#35306 as part of rust-lang#35233. r? @GuillaumeGomez

bors · 2016-08-07T12:48:47Z

⌛ Testing commit f4dd1f9 with merge f5e7a59...

@GuillaumeGomez

Updated error message E0252 Fixes#35306 as part of #35233. r? @GuillaumeGomez

@GuillaumeGomez

Updated error message E0252 Fixesrust-lang#35306 as part of rust-lang#35233. r? @GuillaumeGomez

bors · 2016-08-07T16:43:49Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-no-mir, auto-win-msvc-64-opt-rustbuild
Approved by: GuillaumeGomez
Pushing f5e7a59 to master...

rust-highfive assigned GuillaumeGomez Aug 5, 2016

GuillaumeGomez mentioned this pull request Aug 5, 2016
Rollup of 30 pull requests #35365
Merged

bors added a commit that referenced this pull request Aug 5, 2016
Auto merge of#35362- medzin:E0252, r=GuillaumeGomez
073cbb6
Updated error message E0252 Fixes#35306 as part of #35233. r? @GuillaumeGomez

eddyb mentioned this pull request Aug 6, 2016
Rollup of 21 pull requests #35407
Merged

Updated error message E0252
f4dd1f9

bors added a commit that referenced this pull request Aug 6, 2016
Auto merge of#35362- medzin:E0252, r=GuillaumeGomez
1518459
Updated error message E0252 Fixes#35306 as part of #35233. r? @GuillaumeGomez

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 6, 2016
Rollup merge ofrust-lang#35362- medzin:E0252, r=GuillaumeGomez
fbd7c55
Updated error message E0252 Fixesrust-lang#35306 as part of rust-lang#35233. r? @GuillaumeGomez

sophiajt mentioned this pull request Aug 6, 2016
Rollup of 9 pull requests #35430
Closed

bors added a commit that referenced this pull request Aug 6, 2016
Auto merge of#35430- jonathandturner:rollup, r=jonathandturner
f0d7e4e
Rollup of 9 pull requests - Successful merges: #35362, #35393, #35394, #35402, #35410, #35411, #35413, #35419, #35421 - Failed merges: #35395, #35415

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Rollup merge ofrust-lang#35362- medzin:E0252, r=GuillaumeGomez
7794eb6
Updated error message E0252 Fixesrust-lang#35306 as part of rust-lang#35233. r? @GuillaumeGomez

sophiajt mentioned this pull request Aug 7, 2016
Rollup of 14 pull requests #35441
Closed

bors added a commit that referenced this pull request Aug 7, 2016
Auto merge of#35362- medzin:E0252, r=GuillaumeGomez
f5e7a59
Updated error message E0252 Fixes#35306 as part of #35233. r? @GuillaumeGomez

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Rollup merge ofrust-lang#35362- medzin:E0252, r=GuillaumeGomez
262c91f
Updated error message E0252 Fixesrust-lang#35306 as part of rust-lang#35233. r? @GuillaumeGomez

sophiajt mentioned this pull request Aug 7, 2016
Rollup of 19 pull requests #35462
Closed

bors merged commit f4dd1f9 into rust-lang:masterAug 7, 2016

Uh oh!

Uh oh!

Conversation

medzin commented Aug 5, 2016

Uh oh!

rust-highfive commented Aug 5, 2016

Uh oh!

GuillaumeGomez commented Aug 5, 2016

Uh oh!

bors commented Aug 5, 2016

Uh oh!

GuillaumeGomez commented Aug 5, 2016

Uh oh!

sophiajt commented Aug 5, 2016

Uh oh!

TimNN commented Aug 5, 2016

Uh oh!

bors commented Aug 5, 2016

Uh oh!

sophiajt commented Aug 5, 2016

Uh oh!

bors commented Aug 5, 2016

Uh oh!

sophiajt commented Aug 5, 2016

Uh oh!

bors commented Aug 5, 2016

Uh oh!

GuillaumeGomez commented Aug 6, 2016

Uh oh!

medzin commented Aug 6, 2016

Uh oh!

GuillaumeGomez commented Aug 6, 2016

Uh oh!

bors commented Aug 6, 2016

Uh oh!

bors commented Aug 6, 2016

Uh oh!

bors commented Aug 6, 2016

Uh oh!

sophiajt commented Aug 6, 2016

Uh oh!

bors commented Aug 7, 2016

Uh oh!

bors commented Aug 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants