Uh oh!
There was an error while loading. Please reload this page.
Rollup of 9 pull requests - #35649
Closed
Manishearth wants to merge 20 commits into
Closed
Conversation
The previous implementation of this function was overly conservative with liberal usage of `Option` and `.unwrap()` which in theory never triggers. This commit essentially removes the `Option`s in favor of unsafe implementations, improving the code generation of the fast path for LLVM to see through what's happening more clearly. cc rust-lang#34727
Similar to the `as_slice` method on `core::slice::Iter` struct.
… r=brson std: Optimize panic::catch_unwind slightly The previous implementation of this function was overly conservative with liberal usage of `Option` and `.unwrap()` which in theory never triggers. This commit essentially removes the `Option`s in favor of unsafe implementations, improving the code generation of the fast path for LLVM to see through what's happening more clearly. cc rust-lang#34727
…alexcrichton Introduce `as_slice`/`as_mut_slice` methods on `std::vec::IntoIter` struct. Similar to the `as_slice` method on `core::slice::Iter` struct.
…matsakis Correct span for pub_restricted field Fixrust-lang#35435.
Add regression test for rust-lang#22894. None
…atsakis [MIR] track Location in MirVisitor, combine Location All the users of MirVisitor::visit_statement implement their own statement index tracking. This PR move the tracking into MirVisitor itself. Also, there were 2 separate implementations of Location that were identical. This PR eliminates one of them.
…atsakis
Improve &-ptr printing
This PR replaces printing `&-ptr` with a more readable description. To do so it uses a few heuristics.
If the name of the type is unknown, too long (longer than just saying "reference"), or too complex (a type with explicit lifetime annotations), it will instead opt to print either "reference" or "mutable reference", depending on the mutability of the type.
Before:
```
error[E0308]: mismatched types
--> src/test/compile-fail/issue-7061.rs:14:46
|
14 | fn foo(&'a mut self) -> Box<BarStruct> { self }
| ^^^^ expected box, found &-ptr
|
= note: expected type `Box<BarStruct>`
= note: found type `&'a mut BarStruct`
error: aborting due to previous error
```
After:
```
error[E0308]: mismatched types
--> src/test/compile-fail/issue-7061.rs:14:46
|
14 | fn foo(&'a mut self) -> Box<BarStruct> { self }
| ^^^^ expected box, found mutable reference
|
= note: expected type `Box<BarStruct>`
= note: found type `&'a mut BarStruct`
error: aborting due to previous error
```… r=eddyb Fix incorrect unused import warnings on `cfg_attr`ed `path` attributes Fixesrust-lang#35584. r? @eddyb
Upgrade linkchecker to url 1.2.0.
compiletest: Remove dead code.
Manishearth
commented
Aug 13, 2016
MemberAuthor
@bors r+ p=10 |
rust-highfive
commented
Aug 13, 2016
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
bors
commented
Aug 13, 2016
Collaborator
📌 Commit 570c79d has been approved by |
sophiajt
commented
Aug 13, 2016
Contributor
@bors r- This fails travis |
eddyb
commented
Aug 14, 2016
Contributor
Looks like #35542 has problems after merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as_slice/as_mut_slicemethods onstd::vec::IntoIterstruct. #35447, Correct span for pub_restricted field #35491, Add regression test for #22894. #35533, [MIR] track Location in MirVisitor, combine Location #35542, Improve &-ptr printing #35611, Fix incorrect unused import warnings oncfg_attredpathattributes #35617, Upgrade linkchecker to url 1.2.0. #35638, compiletest: Remove dead code. #35640