Introduce as_slice/as_mut_slice methods on std::vec::IntoIter struct.

[frewsxcv]

Similar to the as_slice method on core::slice::Iter struct.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[apasel422]

This could also have as_slice_mut, no? Would it be better to implement {AsRef, AsMut} instead?

[frewsxcv]

This could also have as_slice_mut, no?

I think so. I can add it in.

Would it be better to implement {AsRef, AsMut} instead?

This works for me too; if anyone has strong opinions on this let me know. core::slice::Iter seems to implement just as_slice. std::vec::Vec seems to implement as_slice and AsRef.

[eddyb]

Aren't trait impls insta-stable?

[alexcrichton]

@bors: r+

Discussed during libs triage and we were ok, thanks @frewsxcv!

[bors]

📌 Commit ce58686 has been approved by alexcrichton

[alexcrichton]

@bors: r-

Er wait actually, could you open a tracking issue for these methods and update the unstable issue reference?

[frewsxcv]

Er wait actually, could you open a tracking issue for these methods and update the unstable issue reference?

Done.

diff --git a/src/libcollections/vec.rs b/src/libcollections/vec.rs
index bce1fca..a6f817a 100644
--- a/src/libcollections/vec.rs+++ b/src/libcollections/vec.rs@@ -1726,7 +1726,7 @@ impl<T> IntoIter<T> {
/// let _ = into_iter.next().unwrap();
/// assert_eq!(into_iter.as_slice(), &['b', 'c']);
/// ```
- #[unstable(feature = "vec_into_iter_as_slice", issue = "0")]+ #[unstable(feature = "vec_into_iter_as_slice", issue = "35601")]
pub fn as_slice(&self) -> &[T] {
unsafe {
slice::from_raw_parts(self.ptr, self.len())
@@ -1747,7 +1747,7 @@ impl<T> IntoIter<T> {
/// assert_eq!(into_iter.next().unwrap(), 'b');
/// assert_eq!(into_iter.next().unwrap(), 'z');
/// ```
- #[unstable(feature = "vec_into_iter_as_slice", issue = "0")]+ #[unstable(feature = "vec_into_iter_as_slice", issue = "35601")]
pub fn as_mut_slice(&self) -> &mut [T] {
unsafe {
slice::from_raw_parts_mut(self.ptr, self.len())

[alexcrichton]

@bors: r+

Thanks!

[bors]

📌 Commit 01a766e has been approved by alexcrichton

[bors]

⌛ Testing commit 01a766e with merge a9a61fb...

[bors]

💔 Test failed - auto-linux-64-debug-opt

[alexcrichton]

@bors: retry

On Sat, Aug 13, 2016 at 8:36 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-debug-opt
https://buildbot.rust-lang.org/builders/auto-linux-64-debug-opt/builds/3467

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#35447 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95K8FYVgO-vNQUD4NVo99BaVxW8s_ks5qfo1XgaJpZM4JebGs
.

[eddyb]

@bors rollup

[apasel422]

The switch from *const T to *mut T caused vec::IntoIter<T> to go from covariant in T to invariant in T, which is a breaking change. (See contain-rs/vec-map#18.)

I thought we had tests for this.

[sfackler]

#39465