Skip to content

Update error message for E0084 - #35804

Merged
bors merged 1 commit into
rust-lang:masterfrom
pliniker:master
Aug 20, 2016
Merged

Update error message for E0084#35804
bors merged 1 commit into
rust-lang:masterfrom
pliniker:master

Conversation

@pliniker

@plinikerpliniker commented Aug 18, 2016

Copy link
Copy Markdown
Contributor

Fixes#35792 as part of #35233

r? @jonathandturner

@rust-highfive

rust-highfive commented Aug 18, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt

sophiajt commented Aug 18, 2016

Copy link
Copy Markdown
Contributor

Looks good!

@bors r+ rollup

@bors

bors commented Aug 18, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 161cb36 has been approved by jonathandturner

@plinikerpliniker reopened this Aug 18, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 18, 2016
@steveklabnik
Rollup merge ofrust-lang#35804- pliniker:master, r=jonathandturner
9dea71e
Update error message for E0084
Fixesrust-lang#35792 as part of rust-lang#35233
r? @jonathandturner
@steveklabniksteveklabnik mentioned this pull request Aug 18, 2016
Closed
@pliniker

pliniker commented Aug 19, 2016

Copy link
Copy Markdown
ContributorAuthor

@jonathandturner thanks for the blog post, following that made this a pleasant contribution experience!

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 19, 2016
Jonathan Turner
Rollup merge ofrust-lang#35804- pliniker:master, r=jonathandturner
20b4b99
Update error message for E0084
Fixesrust-lang#35792 as part of rust-lang#35233
r? @jonathandturner
@sophiajtsophiajt mentioned this pull request Aug 19, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 19, 2016
Jonathan Turner
Rollup merge ofrust-lang#35804- pliniker:master, r=jonathandturner
1136f42
Update error message for E0084
Fixesrust-lang#35792 as part of rust-lang#35233
r? @jonathandturner
@sophiajtsophiajt mentioned this pull request Aug 19, 2016
Closed
@sophiajt

sophiajt commented Aug 19, 2016

Copy link
Copy Markdown
Contributor

@pliniker - great to hear!

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 20, 2016
Jonathan Turner
Rollup merge ofrust-lang#35804- pliniker:master, r=jonathandturner
5bcff96
Update error message for E0084
Fixesrust-lang#35792 as part of rust-lang#35233
r? @jonathandturner
@sophiajtsophiajt mentioned this pull request Aug 20, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 20, 2016
Jonathan Turner
Rollup merge ofrust-lang#35804- pliniker:master, r=jonathandturner
15277eb
Update error message for E0084
Fixesrust-lang#35792 as part of rust-lang#35233
r? @jonathandturner
@sophiajtsophiajt mentioned this pull request Aug 20, 2016
Merged
bors added a commit that referenced this pull request Aug 20, 2016
@bors
Auto merge of#35857- jonathandturner:rollup, r=jonathandturner
4901896
Rollup of 19 pull requests
- Successful merges: #35234, #35701, #35709, #35710, #35775, #35778, #35780, #35781, #35794, #35800, #35804, #35806, #35811, #35812, #35818, #35827, #35830, #35831, #35839
- Failed merges: #35759
@bors
bors merged commit 161cb36 into rust-lang:masterAug 20, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sophiajtsophiajt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pliniker@rust-highfive@sophiajt@bors