Uh oh!
There was an error while loading. Please reload this page.
Add workaround to detect correct compiler version - #35811
Merged
Conversation
alexcrichton
commented
Aug 18, 2016
Member
@bors: r+ |
bors
commented
Aug 18, 2016
Collaborator
📌 Commit ffbb860 has been approved by |
sophiajt
commented
Aug 19, 2016
ContributorAuthor
@bors r- This doesn't seem to fix the issue. |
sophiajt
commented
Aug 19, 2016
ContributorAuthor
Oops, just kidding. I thought I was running on this branch but I'm not. False alarm :) |
sophiajt
commented
Aug 19, 2016
ContributorAuthor
@bors r=alexcrichton |
bors
commented
Aug 19, 2016
Collaborator
📌 Commit ffbb860 has been approved by |
sophiajt
commented
Aug 19, 2016
ContributorAuthor
@bors rollup |
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 19, 2016
…on_test, r=alexcrichton Add workaround to detect correct compiler version This adds a workaround which fixes a rustbuild issue where the wrong compiler is checked for the version number. The bug would arise if you build the system correctly then changed to any other version (eg doing a `git pull`). After changing to the new version, building would fail and complain that crates were built with the wrong compiler. There are actually two compilers at play, the bootstrapping compiler (called the "snapshot" compiler) and the actual compiler being built (the "real" compiler). In the case of this issue, the wrong compiler was being checked for version mismatch. r? @alexcrichton
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 20, 2016
…on_test, r=alexcrichton Add workaround to detect correct compiler version This adds a workaround which fixes a rustbuild issue where the wrong compiler is checked for the version number. The bug would arise if you build the system correctly then changed to any other version (eg doing a `git pull`). After changing to the new version, building would fail and complain that crates were built with the wrong compiler. There are actually two compilers at play, the bootstrapping compiler (called the "snapshot" compiler) and the actual compiler being built (the "real" compiler). In the case of this issue, the wrong compiler was being checked for version mismatch. r? @alexcrichton
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 20, 2016
…on_test, r=alexcrichton Add workaround to detect correct compiler version This adds a workaround which fixes a rustbuild issue where the wrong compiler is checked for the version number. The bug would arise if you build the system correctly then changed to any other version (eg doing a `git pull`). After changing to the new version, building would fail and complain that crates were built with the wrong compiler. There are actually two compilers at play, the bootstrapping compiler (called the "snapshot" compiler) and the actual compiler being built (the "real" compiler). In the case of this issue, the wrong compiler was being checked for version mismatch. r? @alexcrichton
bors added a commit
that referenced
this pull request
Aug 20, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a workaround which fixes a rustbuild issue where the wrong compiler is checked for the version number. The bug would arise if you build the system correctly then changed to any other version (eg doing a
git pull). After changing to the new version, building would fail and complain that crates were built with the wrong compiler.There are actually two compilers at play, the bootstrapping compiler (called the "snapshot" compiler) and the actual compiler being built (the "real" compiler). In the case of this issue, the wrong compiler was being checked for version mismatch.
r? @alexcrichton