Skip to content

Update E0424 to the new error format - #35841

Merged
bors merged 1 commit into
rust-lang:masterfrom
kyrias:new-error-E0424
Aug 23, 2016
Merged

Update E0424 to the new error format#35841
bors merged 1 commit into
rust-lang:masterfrom
kyrias:new-error-E0424

Conversation

@kyrias

@kyriaskyrias commented Aug 20, 2016

Copy link
Copy Markdown
Contributor

Fixes#35797.
Part of #35233.

r? @GuillaumeGomez

@rust-highfive

rust-highfive commented Aug 20, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez
GuillaumeGomez reviewed Aug 20, 2016
View reviewed changes
Comment threadsrc/test/compile-fail/issue-2356.rs Outdated

@GuillaumeGomezGuillaumeGomezAug 20, 2016•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the note you added (like you did in E0424 file).

@kyrias

kyrias commented Aug 20, 2016

Copy link
Copy Markdown
ContributorAuthor

Ah, added that afterwards and forgot to check the diff of the first file.

@GuillaumeGomez

GuillaumeGomez commented Aug 20, 2016

Copy link
Copy Markdown
Member

No problem. Please squash your commits and then I r+.

@kyrias
Update E0424 to the new error format
ff44f08
Fixes#35797.
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
@kyrias

kyrias commented Aug 20, 2016

Copy link
Copy Markdown
ContributorAuthor

Squashed!

@GuillaumeGomez

GuillaumeGomez commented Aug 20, 2016

Copy link
Copy Markdown
Member

Thanks!

@bors: r+ rollup

@bors

bors commented Aug 20, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit ff44f08 has been approved by GuillaumeGomez

@eddybeddyb mentioned this pull request Aug 22, 2016
Closed
eddyb added a commit to eddyb/rust that referenced this pull request Aug 22, 2016
@eddyb
Rollup merge ofrust-lang#35841- kyrias:new-error-E0424, r=Guillaume…
bd51f76
…Gomez
Update E0424 to the new error format
Fixesrust-lang#35797.
Part of rust-lang#35233.
r? @GuillaumeGomez
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 22, 2016
Jonathan Turner
Rollup merge ofrust-lang#35841- kyrias:new-error-E0424, r=Guillaume…
ddaf109
…Gomez
Update E0424 to the new error format
Fixesrust-lang#35797.
Part of rust-lang#35233.
r? @GuillaumeGomez
@sophiajtsophiajt mentioned this pull request Aug 22, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 22, 2016
Jonathan Turner
Rollup merge ofrust-lang#35841- kyrias:new-error-E0424, r=Guillaume…
cc51d1c
…Gomez
Update E0424 to the new error format
Fixesrust-lang#35797.
Part of rust-lang#35233.
r? @GuillaumeGomez
@sophiajtsophiajt mentioned this pull request Aug 22, 2016
Merged
bors added a commit that referenced this pull request Aug 22, 2016
@bors
Auto merge of#35908- jonathandturner:rollup, r=jonathandturner
d0da7f6
Rollup of 20 pull requests
- Successful merges: #35360, #35526, #35809, #35817, #35820, #35824, #35835, #35841, #35842, #35858, #35860, #35861, #35864, #35878, #35879, #35881, #35882, #35889, #35891, #35901
- Failed merges: #35395
@bors

bors commented Aug 23, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #35908) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
bors merged commit ff44f08 into rust-lang:masterAug 23, 2016
@kyrias
kyrias deleted the new-error-E0424 branch August 23, 2016 08:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kyrias@rust-highfive@GuillaumeGomez@bors