Skip to content

Minor typo in CONTRIBUTING.md - #35889

Merged
bors merged 1 commit into
rust-lang:masterfrom
alevy:patch-1
Aug 23, 2016
Merged

Minor typo in CONTRIBUTING.md#35889
bors merged 1 commit into
rust-lang:masterfrom
alevy:patch-1

Conversation

@alevy

@alevyalevy commented Aug 22, 2016

Copy link
Copy Markdown
Contributor

A single missing article

@alevy
Minor type in CONTRIBUTING.md
4b6477f
A single missing article
@rust-highfive

rust-highfive commented Aug 22, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@munyari

munyari commented Aug 22, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Ironically, you have a typo in your commit message/PR title :)

@GuillaumeGomez

GuillaumeGomez commented Aug 22, 2016

Copy link
Copy Markdown
Member

@munyari: I thought I didn't understand something. 😄

@alevy: Thanks!

@bors: r+ rollup

@bors

bors commented Aug 22, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 4b6477f has been approved by GuillaumeGomez

@alevyalevy changed the title Minor type in CONTRIBUTING.mdMinor typo in CONTRIBUTING.mdAug 22, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 22, 2016
Jonathan Turner
Rollup merge ofrust-lang#35889- alevy:patch-1, r=GuillaumeGomez
1e5d804
Minor type in CONTRIBUTING.md
A single missing article
@sophiajtsophiajt mentioned this pull request Aug 22, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 22, 2016
Jonathan Turner
Rollup merge ofrust-lang#35889- alevy:patch-1, r=GuillaumeGomez
766b04e
Minor type in CONTRIBUTING.md
A single missing article
@sophiajtsophiajt mentioned this pull request Aug 22, 2016
Merged
bors added a commit that referenced this pull request Aug 22, 2016
@bors
Auto merge of#35908- jonathandturner:rollup, r=jonathandturner
d0da7f6
Rollup of 20 pull requests
- Successful merges: #35360, #35526, #35809, #35817, #35820, #35824, #35835, #35841, #35842, #35858, #35860, #35861, #35864, #35878, #35879, #35881, #35882, #35889, #35891, #35901
- Failed merges: #35395
@bors
bors merged commit 4b6477f into rust-lang:masterAug 23, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alevy@rust-highfive@munyari@GuillaumeGomez@bors@alexcrichton