Indicate where `core::result::IntoIter` is created. by frewsxcv · Pull Request #35845 · rust-lang/rust

frewsxcv · 2016-08-20T01:45:55Z

No description provided.

frewsxcv · 2016-08-20T18:28:52Z

GuillaumeGomez · 2016-08-20T23:33:29Z

You don't have to write "[Result][Result]". Just "[Result]" is fine.
Can you also urls for into_iter please?

You don't have to write "[Result][Result]". Just "[Result]" is fine.
I need to, otherwise, it will treat
[`Result`] (provided by the [`IntoIterator`] trait).
as a standard markdown link [...](...)

Latest force push adds a link for into_iter.

GuillaumeGomez · 2016-08-21T10:34:05Z

Thanks!

@bors: r+ rollup

bors · 2016-08-21T10:34:06Z

📌 Commit f4d55e1 has been approved by GuillaumeGomez

…umeGomez Indicate where `core::result::IntoIter` is created. None

sophiajt · 2016-08-22T22:31:39Z

@bors r-

Looks like this might have some broken links on OS X. This is from the latest rollup:

Linkcheck stage2 (x86_64-apple-darwin)
core/result/index.html:392: broken link - core/result/struct.Result.html
core/result/struct.IntoIter.html:54: broken link - core/result/struct.Result.html
std/path/struct.Path.html:474: broken link - std/path/ffi/struct.OsStr.html
std/path/struct.Path.html:496: broken link - std/path/fmt/trait.Display.html
std/path/struct.PathBuf.html:598: broken link - std/path/ffi/struct.OsStr.html
std/path/struct.PathBuf.html:620: broken link - std/path/fmt/trait.Display.html
std/result/index.html:392: broken link - std/result/struct.Result.html
std/result/struct.IntoIter.html:54: broken link - std/result/struct.Result.html

sophiajt · 2016-08-22T22:37:26Z

Looks like #35786 has a similar issue. Maybe we can work together on a fix and apply to both?

frewsxcv · 2016-08-27T16:29:08Z

@GuillaumeGomez Did you ever find out what the issue was?

GuillaumeGomez · 2016-08-27T18:27:28Z

@frewsxcv: Random tries mainly.

frewsxcv · 2016-09-03T23:37:48Z

@GuillaumeGomez Tests pass now. r?

GuillaumeGomez · 2016-09-04T09:33:41Z

@bors: r+ rollup

bors · 2016-09-04T09:33:42Z

📌 Commit 5652b62 has been approved by GuillaumeGomez

…umeGomez Indicate where `core::result::IntoIter` is created. None

bors · 2016-09-05T21:41:16Z

⌛ Testing commit 5652b62 with merge cbe4de7...

Indicate where `core::result::IntoIter` is created. None

bors · 2016-09-06T00:55:43Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: GuillaumeGomez
Pushing cbe4de7 to master...

Rollup of 6 pull requests - Successful merges: #35845, #35983, #36065, #36102, #36242, #36245 - Failed merges:

rust-highfive assigned GuillaumeGomez Aug 20, 2016

GuillaumeGomez reviewed Aug 20, 2016
View reviewed changes

frewsxcv force-pushed the result-into-iter branch from 25bf2e5 to f4d55e1Compare August 20, 2016 23:41

eddyb mentioned this pull request Aug 22, 2016
Rollup of 11 pull requests #35893
Closed

eddyb added a commit to eddyb/rust that referenced this pull request Aug 22, 2016
Rollup merge ofrust-lang#35845- frewsxcv:result-into-iter, r=Guilla…
3e56c62
…umeGomez Indicate where `core::result::IntoIter` is created. None

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 22, 2016
Rollup merge ofrust-lang#35845- frewsxcv:result-into-iter, r=Guilla…
ca86803
…umeGomez Indicate where `core::result::IntoIter` is created. None

sophiajt mentioned this pull request Aug 22, 2016
Rollup of 15 pull requests #35898
Closed

frewsxcv mentioned this pull request Aug 23, 2016
Travis CI should run linkchecker #35921
Closed

frewsxcv force-pushed the result-into-iter branch from f4d55e1 to 42736c3Compare August 27, 2016 16:19

frewsxcv force-pushed the result-into-iter branch 2 times, most recently from 63259fc to e5af9efCompare September 3, 2016 16:12

Indicate where core::result::IntoIter is created.
5652b62

frewsxcv force-pushed the result-into-iter branch from e5af9ef to 5652b62Compare September 3, 2016 20:56

Manishearth mentioned this pull request Sep 5, 2016
Rollup of 6 pull requests #36274
Merged

Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 5, 2016
Rollup merge ofrust-lang#35845- frewsxcv:result-into-iter, r=Guilla…
acf98d9
…umeGomez Indicate where `core::result::IntoIter` is created. None

bors added a commit that referenced this pull request Sep 5, 2016
Auto merge of#35845- frewsxcv:result-into-iter, r=GuillaumeGomez
cbe4de7
Indicate where `core::result::IntoIter` is created. None

bors added a commit that referenced this pull request Sep 6, 2016
Auto merge of#36274- Manishearth:rollup, r=Manishearth
e1d0de8
Rollup of 6 pull requests - Successful merges: #35845, #35983, #36065, #36102, #36242, #36245 - Failed merges:

bors merged commit 5652b62 into rust-lang:masterSep 6, 2016

frewsxcv deleted the result-into-iter branch October 2, 2016 23:06

Uh oh!

Uh oh!

Conversation

frewsxcv commented Aug 20, 2016

Uh oh!

frewsxcv commented Aug 20, 2016

Uh oh!

GuillaumeGomezAug 20, 2016

Choose a reason for hiding this comment

Uh oh!

frewsxcvAug 20, 2016

Choose a reason for hiding this comment

Uh oh!

frewsxcvAug 20, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Aug 21, 2016

Uh oh!

bors commented Aug 21, 2016

Uh oh!

sophiajt commented Aug 22, 2016

Uh oh!

sophiajt commented Aug 22, 2016

Uh oh!

frewsxcv commented Aug 27, 2016

Uh oh!

GuillaumeGomez commented Aug 27, 2016

Uh oh!

frewsxcv commented Sep 3, 2016

Uh oh!

GuillaumeGomez commented Sep 4, 2016

Uh oh!

bors commented Sep 4, 2016

Uh oh!

bors commented Sep 5, 2016

Uh oh!

bors commented Sep 6, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants