Skip to content

Update E0496 to new format - #36065

Merged
bors merged 1 commit into
rust-lang:masterfrom
acrrd:new_format_E0496
Sep 6, 2016
Merged

Update E0496 to new format#36065
bors merged 1 commit into
rust-lang:masterfrom
acrrd:new_format_E0496

Conversation

@acrrd

Copy link
Copy Markdown
Contributor

Fixes#36000.
Part of #35233.

r? @GuillaumeGomez

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

I wait for travis' confirmation before r+ it.

Also, can you squash your commits please? If you don't know how to do, take a look here.

@CryZe

Copy link
Copy Markdown
Contributor

Travis won't confirm, it's broken right now.

@acrrd

Copy link
Copy Markdown
ContributorAuthor

squash done

@GuillaumeGomez

Copy link
Copy Markdown
Member

@acrrd: Travis and buildbot are broken for the moment. Once they're fixed, I'll r+.

@acrrd

Copy link
Copy Markdown
ContributorAuthor

There are some tests that fails, these are tests that check the warning and not the error; with my modifications the label of the warning also changed, is what we want?

(I run make check-stage1, it ends with
test result: ok. 2494 passed; 0 failed; 3 ignored; 0 measured
and only if I scroll a lot up I found
test result: FAILED. 2523 passed; 5 failed; 13 ignored; 0 measured
is there a better way to see the summary of the result of the tests?)

@GuillaumeGomez

Copy link
Copy Markdown
Member

Sure:

make check-stage1-cfail

@acrrd

Copy link
Copy Markdown
ContributorAuthor

Thanks, that will help in avoiding to send PR with tests that do not pass.

What about the tests? I can modify them to the new format also for the warning or I can modify the code the keep the old behavior for the warning.

@GuillaumeGomez

Copy link
Copy Markdown
Member

Just check what the command will return. It'll tell you what you need to update (and how).

@acrrd

acrrd commented Sep 3, 2016

Copy link
Copy Markdown
ContributorAuthor

I have the fail also on master so I think my commit is ok

@GuillaumeGomez

Copy link
Copy Markdown
Member

Seems good. Thanks!

@bors: r+ rollup

@bors

bors commented Sep 4, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 63671c4 has been approved by GuillaumeGomez

@ManishearthManishearth mentioned this pull request Sep 5, 2016
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 5, 2016
bors added a commit that referenced this pull request Sep 6, 2016
Rollup of 6 pull requests
- Successful merges: #35845, #35983, #36065, #36102, #36242, #36245
- Failed merges:
@bors
bors merged commit 63671c4 into rust-lang:masterSep 6, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@acrrd@rust-highfive@GuillaumeGomez@CryZe@bors