Uh oh!
There was an error while loading. Please reload this page.
Update E0496 to new format - #36065
Conversation
rust-highfive
commented
Aug 28, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
GuillaumeGomez
commented
Aug 28, 2016
Thanks! I wait for travis' confirmation before r+ it. Also, can you squash your commits please? If you don't know how to do, take a look here. |
CryZe
commented
Aug 28, 2016
Travis won't confirm, it's broken right now. |
acrrd
commented
Aug 28, 2016
squash done |
GuillaumeGomez
commented
Aug 29, 2016
@acrrd: Travis and buildbot are broken for the moment. Once they're fixed, I'll r+. |
acrrd
commented
Aug 31, 2016
There are some tests that fails, these are tests that check the warning and not the error; with my modifications the label of the warning also changed, is what we want? (I run make check-stage1, it ends with |
GuillaumeGomez
commented
Aug 31, 2016
Sure: make check-stage1-cfail |
acrrd
commented
Aug 31, 2016
Thanks, that will help in avoiding to send PR with tests that do not pass. What about the tests? I can modify them to the new format also for the warning or I can modify the code the keep the old behavior for the warning. |
GuillaumeGomez
commented
Sep 1, 2016
Just check what the command will return. It'll tell you what you need to update (and how). |
acrrd
commented
Sep 3, 2016
I have the fail also on master so I think my commit is ok |
GuillaumeGomez
commented
Sep 4, 2016
Seems good. Thanks! @bors: r+ rollup |
bors
commented
Sep 4, 2016
📌 Commit 63671c4 has been approved by |
…Gomez Update E0496 to new format Fixesrust-lang#36000. Part of rust-lang#35233. r? @GuillaumeGomez
Fixes#36000.
Part of #35233.
r? @GuillaumeGomez