Uh oh!
There was an error while loading. Please reload this page.
Update E0453 to new error format - #35989
Conversation
rust-highfive
commented
Aug 25, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
sophiajt
commented
Aug 25, 2016
Looks good! @bors r+ rollup |
bors
commented
Aug 25, 2016
📌 Commit dc5bb80 has been approved by |
sophiajt
commented
Aug 25, 2016
@bors r+ rollup |
bors
commented
Aug 25, 2016
📌 Commit feeae00 has been approved by |
sophiajt
commented
Aug 25, 2016
@bors r- I'll stop approving while you work ;) Just ping me again when you're ready. If you would, please squash the PRs. |
ccaafee to
e4871c4Compare0xmohit
commented
Aug 25, 2016
@jonathandturner Done. Moral of the story: always test before submitting a PR ;) |
sophiajt
commented
Aug 25, 2016
bors
commented
Aug 25, 2016
📌 Commit e4871c4 has been approved by |
…thandturner Update E0453 to new error format Fixesrust-lang#35929. Part of rust-lang#35233. r? @jonathandturner
0xmohit
commented
Aug 26, 2016
The failure appears due to a test in src/test/compile-fail-fulldeps/. Figuring. |
sophiajt
commented
Aug 26, 2016
For those I think you may need to test against check-cfail-full. Possibly at stage 2 |
d6e8561 to
88e4defCompare0xmohit
commented
Aug 26, 2016
Tested against both |
sophiajt
commented
Aug 26, 2016
Great. Let's give it a try. @bors r+ rollup |
bors
commented
Aug 26, 2016
📌 Commit 88e4def has been approved by |
…thandturner Update E0453 to new error format Fixesrust-lang#35929. Part of rust-lang#35233. r? @jonathandturner
…thandturner Update E0453 to new error format Fixesrust-lang#35929. Part of rust-lang#35233. r? @jonathandturner
Fixes#35929.
Part of #35233.
r? @jonathandturner