Uh oh!
There was an error while loading. Please reload this page.
Rollup of 11 pull requests - #35994
Closed
steveklabnik wants to merge 26 commits into
Closed
Conversation
Doing otherwise would break traits like `ToString`.
This pull request adds a module-level example of how all the range operators work. It also slims down struct-level examples in lieu of a link to module examples. add feature for inclusive_range_syntax fix incorrectly closed code fences
r? @steveklabnik add links for Box, Rc, and Vec
They're the same thing but it's better to keep the terminology consistent.
PR rust-lang#35695 for `Range` was approved, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`. add `fn main` wrappers to enable Rust Playground "Run" button
r? @steveklabnik add examples that lift `<<` and `>>` to a trivial struct replace `Scalar` structs with struct tuples add `fn main` wrappers to enable Rust Playground "Run" button
The affected API apparently had changed with commit d59accf.
Fixesrust-lang#35966. Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
…les, r=steveklabnik refactor range examples This pull request adds a module-level example of how all the range operators work. It also slims down struct-level examples in lieu of a link to module examples.
…abnik Improve Path and PathBuf docs r? @steveklabnik
Clarify/fix formatting docs concerning fmt::Result/fmt::Error 1. `fmt::Result` != `io::Result<()>` 2. Formatters should only propagate errors, not return their own. Confusion on reddit: https://www.reddit.com/r/rust/comments/4yorxr/is_implt_tostring_for_t_where_t_display_sized_a/
…klabnik add evocative examples for `Shl` and `Shr` r? @steveklabnik
…klabnik add links to interesting items in `std::ptr` documentation r? @steveklabnik
…steveklabnik Updated code sample in chapter on syntax extensions. The affected API apparently had changed with commit d59accf. --- Further more I had to add ```toml [lib] name = "roman_numerals" crate-type = ["dylib"] ``` to `Cargo.toml` as I otherwise got this compiler error (despite `#![crate_type="dylib"]`): [E0457]: plugin `roman_numerals` only found in rlib format, but must be available in dylib format Might be worth adding a note about that?
Rename {int,uint} methods to {isize,usize}.
None…turner Make E0094 underline better r? @jonathandturner
…thandturner Update E0277 to new error format Fixesrust-lang#35311. Part of rust-lang#35233. r? @jonathandturner
…thandturner Update E0453 to new error format Fixesrust-lang#35929. Part of rust-lang#35233. r? @jonathandturner
steveklabnik
commented
Aug 25, 2016
ContributorAuthor
@bors: r+ p=1 |
bors
commented
Aug 25, 2016
Collaborator
📌 Commit c1c6d6c has been approved by |
rust-highfive
commented
Aug 25, 2016
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
bors
commented
Aug 25, 2016
Collaborator
⌛ Testing commit c1c6d6c with merge 87f544c... |
bors
commented
Aug 25, 2016
Collaborator
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShlandShr#35863, add links to interesting items instd::ptrdocumentation #35880, Updated code sample in chapter on syntax extensions. #35962, Rename {int,uint} methods to {isize,usize}. #35977, Make E0094 underline better #35980, Update E0277 to new error format #35985, Update E0453 to new error format #35989RangeToandRangeToInclusivefails #35771, improve documentation forFn*traits #35810