Uh oh!
There was an error while loading. Please reload this page.
Update lifetime errors to specifically note temporaries - #36171
Merged
Conversation
Contributor
There was a problem hiding this comment.
Nit: can we make this a UI test?
nikomatsakis
commented
Aug 31, 2016
Contributor
@jonathandturner r=me if we move the "suggestions" to a |
sophiajt
commented
Aug 31, 2016
ContributorAuthor
@bors r=nikomatsakis |
bors
commented
Aug 31, 2016
Collaborator
📌 Commit 5112b40 has been approved by |
Contributor
There was a problem hiding this comment.
Trailing whitespace. make tidy won't be happy.
sophiajtforce-pushed
the
temporary_value
branch
from
September 1, 2016 00:48
5112b40 to
439afcdComparesophiajt
commented
Sep 1, 2016
ContributorAuthor
@bors r=nikomatsakis |
bors
commented
Sep 1, 2016
Collaborator
📌 Commit 439afcd has been approved by |
sophiajt
commented
Sep 1, 2016
ContributorAuthor
@frewsxcv - thanks for the catch with tidy :) |
sophiajt
commented
Sep 2, 2016
ContributorAuthor
@bors rollup |
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 2, 2016
…nikomatsakis Update lifetime errors to specifically note temporaries This PR updates the error message we give in the case of a temporary value not living long enough. Before: <img width="497" alt="screen shot 2016-08-31 at 10 02 47 am" src="https://cloud.githubusercontent.com/assets/547158/18138551/27a06794-6f62-11e6-9ee2-bdf8bed75ca7.png"> Now: <img width="488" alt="screen shot 2016-08-31 at 10 03 01 am" src="https://cloud.githubusercontent.com/assets/547158/18138557/2e5cf322-6f62-11e6-9047-4a78abf3d78c.png"> Specifically, it makes the following changes: * Detects if a temporary is being used. If so, it changes the labels to mention that a temporary value specifically is in question * Simplifies wording of the existing labels to focus on lifetimes rather than values being valid * Changes the help to a note, since the help+span wasn't as helpful (and sometimes more confusing) than just a note. r? @nikomatsakis
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 2, 2016
…nikomatsakis Update lifetime errors to specifically note temporaries This PR updates the error message we give in the case of a temporary value not living long enough. Before: <img width="497" alt="screen shot 2016-08-31 at 10 02 47 am" src="https://cloud.githubusercontent.com/assets/547158/18138551/27a06794-6f62-11e6-9ee2-bdf8bed75ca7.png"> Now: <img width="488" alt="screen shot 2016-08-31 at 10 03 01 am" src="https://cloud.githubusercontent.com/assets/547158/18138557/2e5cf322-6f62-11e6-9047-4a78abf3d78c.png"> Specifically, it makes the following changes: * Detects if a temporary is being used. If so, it changes the labels to mention that a temporary value specifically is in question * Simplifies wording of the existing labels to focus on lifetimes rather than values being valid * Changes the help to a note, since the help+span wasn't as helpful (and sometimes more confusing) than just a note. r? @nikomatsakis
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 2, 2016
…nikomatsakis Update lifetime errors to specifically note temporaries This PR updates the error message we give in the case of a temporary value not living long enough. Before: <img width="497" alt="screen shot 2016-08-31 at 10 02 47 am" src="https://cloud.githubusercontent.com/assets/547158/18138551/27a06794-6f62-11e6-9ee2-bdf8bed75ca7.png"> Now: <img width="488" alt="screen shot 2016-08-31 at 10 03 01 am" src="https://cloud.githubusercontent.com/assets/547158/18138557/2e5cf322-6f62-11e6-9047-4a78abf3d78c.png"> Specifically, it makes the following changes: * Detects if a temporary is being used. If so, it changes the labels to mention that a temporary value specifically is in question * Simplifies wording of the existing labels to focus on lifetimes rather than values being valid * Changes the help to a note, since the help+span wasn't as helpful (and sometimes more confusing) than just a note. r? @nikomatsakis
nikomatsakis
commented
Sep 3, 2016
Contributor
Yay :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the error message we give in the case of a temporary value not living long enough.
Before:
Now:
Specifically, it makes the following changes:
r? @nikomatsakis