Skip to content

Fixed E0528 label and unit test - #36205

Merged
bors merged 1 commit into
rust-lang:masterfrom
EugeneGonzalez:E0528
Sep 3, 2016
Merged

Fixed E0528 label and unit test#36205
bors merged 1 commit into
rust-lang:masterfrom
EugeneGonzalez:E0528

Conversation

@EugeneGonzalez

@EugeneGonzalezEugeneGonzalez commented Sep 1, 2016

Copy link
Copy Markdown

@rust-highfive

rust-highfive commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@EugeneGonzalez

EugeneGonzalez commented Sep 2, 2016

Copy link
Copy Markdown
Author

@jonathandturner this is ready for review. Travis-CI failed because of #36138.

@sophiajt

sophiajt commented Sep 2, 2016

Copy link
Copy Markdown
Contributor

Looks good.

@bors r+ rollup

@bors

bors commented Sep 2, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 7cd4e7f has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 2, 2016
Jonathan Turner
Rollup merge ofrust-lang#36205- EugeneGonzalez:E0528, r=jonathandtu…
12c7a91
…rner
Fixed E0528 label and unit test
Fixesrust-lang#36194 part of rust-lang#35233.
r? @jonathandturner
@sophiajtsophiajt mentioned this pull request Sep 2, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 2, 2016
Jonathan Turner
Rollup merge ofrust-lang#36205- EugeneGonzalez:E0528, r=jonathandtu…
5a1661a
…rner
Fixed E0528 label and unit test
Fixesrust-lang#36194 part of rust-lang#35233.
r? @jonathandturner
@sophiajtsophiajt mentioned this pull request Sep 2, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 2, 2016
Jonathan Turner
Rollup merge ofrust-lang#36205- EugeneGonzalez:E0528, r=jonathandtu…
6736bad
…rner
Fixed E0528 label and unit test
Fixesrust-lang#36194 part of rust-lang#35233.
r? @jonathandturner
@sophiajtsophiajt mentioned this pull request Sep 2, 2016
Merged
bors added a commit that referenced this pull request Sep 3, 2016
@bors
Auto merge of#36227- jonathandturner:rollup, r=jonathandturner
100b309
Rollup of 12 pull requests
- Successful merges: #35754, #35793, #36099, #36160, #36171, #36178, #36180, #36190, #36198, #36205, #36210, #36223
- Failed merges:
@bors
bors merged commit 7cd4e7f into rust-lang:masterSep 3, 2016
@EugeneGonzalez
EugeneGonzalez deleted the E0528 branch September 3, 2016 07:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sophiajtsophiajt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EugeneGonzalez@rust-highfive@sophiajt@bors