Skip to content

Update to new macro url syntax - #36535

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:macro_url
Sep 30, 2016
Merged

Update to new macro url syntax#36535
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:macro_url

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Sep 16, 2016

Copy link
Copy Markdown
Member

Mark-Simulacrum
Mark-Simulacrum approved these changes Sep 16, 2016
View reviewed changes
Comment threadsrc/libcore/fmt/mod.rs Outdated

@Mark-SimulacrumMark-SimulacrumSep 16, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be changed to "[write!]" instead of [write_macro] while we're here?

@GuillaumeGomezGuillaumeGomezSep 16, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not!

@GuillaumeGomez

GuillaumeGomez commented Sep 16, 2016

Copy link
Copy Markdown
MemberAuthor

Next, I think about removing the actual compatibility with the old url macro syntax. If people have opinion?

@steveklabnik

steveklabnik commented Sep 17, 2016

Copy link
Copy Markdown
Contributor

Next, I think about removing the actual compatibility with the old url macro syntax. If people have opinion?

we should leave it in for a little while

@GuillaumeGomez

GuillaumeGomez commented Sep 18, 2016

Copy link
Copy Markdown
MemberAuthor

Ok. So I guess this is ready to get merged?

@GuillaumeGomez

GuillaumeGomez commented Sep 24, 2016

Copy link
Copy Markdown
MemberAuthor

@steveklabnik: ping

@steveklabnik

steveklabnik commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented Sep 30, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit f6ab636 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Sep 30, 2016
@steveklabnik
Rollup merge ofrust-lang#36535- GuillaumeGomez:macro_url, r=stevekl…
dcec48d
…abnik
Update to new macro url syntax
r? @steveklabnik
@steveklabniksteveklabnik mentioned this pull request Sep 30, 2016
Merged
bors added a commit that referenced this pull request Sep 30, 2016
@bors
Auto merge of#36864- steveklabnik:rollup, r=steveklabnik
50932b5
Rollup of 13 pull requests
- Successful merges: #36529, #36535, #36576, #36623, #36711, #36750, #36810, #36829, #36833, #36841, #36842, #36851, #36860
- Failed merges:
@bors
bors merged commit f6ab636 into rust-lang:masterSep 30, 2016
@GuillaumeGomez
GuillaumeGomez deleted the macro_url branch October 1, 2016 08:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum approved these changes

Assignees

@steveklabniksteveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@steveklabnik@bors@Mark-Simulacrum