Uh oh!
There was an error while loading. Please reload this page.
Rollup of 13 pull requests - #36864
Merged
Merged
Conversation
Use examples and placeholder variable names with more meaning, to not make it so abstract.
While reading this, the comment made it difficult for me to simply absorb the concept. It interrupted my reading flow, and I think this expresses the same meaning, but reads a bit better.
Repalce timestamp with a system time, to be more consistent with remaining documentation.
Clarify Index/IndexMut trait docs Use examples and placeholder variable names with more meaning, to not make it so abstract.
…abnik Update to new macro url syntax r? @steveklabnik
…bnik Add missing urls for Box doc r? @steveklabnik
…abnik Fix some typos and improve doc comments style r? @steveklabnik
Suggesting a change to a comment that puzzled me While reading this, the comment made it difficult for me to simply absorb the concept. It interrupted my reading flow, and I think this expresses the same meaning, but reads a bit better. It's trivial, but makes it easier for me to move on to the next line.
Add missing links on cmp module r? @steveklabnik
Add missing urls for ops module Part of rust-lang#29365. r? @steveklabnik
…hton Fix typo in RELEASES.md
…labnik Reword description of SystemTimeError. Repalce timestamp with a system time, to be more consistent with remaining documentation. r? @steveklabnik
…klabnik Improve process module doc a bit r? @steveklabnik
Fixed wrong link in release notes The link for the pull request updating hash_map to implement Debug was a copy of the previous link, this changes the link to the correct PR.
Fix BufRead::read_until documentation. Second paragraph already fully explains what happens when EOF is encountered. The third paragraph (removed one) is spurious and misleading.
Add `Send` and `Sync` traits to the reference Fixesrust-lang#36859
steveklabnik
commented
Sep 30, 2016
ContributorAuthor
@bors: r+ p=1 |
bors
commented
Sep 30, 2016
Collaborator
📌 Commit af1df98 has been approved by |
rust-highfive
commented
Sep 30, 2016
Contributor
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
bors
commented
Sep 30, 2016
Collaborator
bors
commented
Sep 30, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SendandSynctraits to the reference #36860