Skip to content

Stabilize .. in tuple (struct) patterns - #36843

Merged
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:dotstab
Nov 8, 2016
Merged

Stabilize .. in tuple (struct) patterns#36843
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:dotstab

Conversation

@petrochenkov

@petrochenkovpetrochenkov commented Sep 29, 2016

Copy link
Copy Markdown
Contributor

I'd like to nominate .. in tuple and tuple struct patterns for stabilization.
This feature is a relatively small extension to existing stable functionality and doesn't have known blockers.
The feature first appeared in Rust 1.10 6 months ago.
An example of use: #36203

Closes#33627
r? @nikomatsakis

@brsonbrson added I-nominated T-lang Relevant to the language team relnotes Marks issues that should be documented in the release notes of the next release. labels Sep 30, 2016
@nikomatsakis

nikomatsakis commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

cc @rust-lang/lang -- thoughts on stabilizing Foo(x, ..)? <-- @petrochenkov that's what this is about, right?

@petrochenkov

petrochenkov commented Oct 4, 2016

Copy link
Copy Markdown
ContributorAuthor

Foo(x, ..)? <-- that's what this is about, right?

Right

@nrc

nrc commented Oct 4, 2016

Copy link
Copy Markdown
Member

I'd be happy for the tracking issue to be in FCP this cycle. I don't feel any pressure to fast track stabilisation.

@petrochenkov

petrochenkov commented Oct 4, 2016

Copy link
Copy Markdown
ContributorAuthor

I'd be happy for the tracking issue to be in FCP this cycle.

Let's assume the FCP starts now5 days ago then?
(I also posted a note on stabilization a couple of cycles ago #33627 (comment), but nobody finally-commented on it, I should probably make such notes more officially looking in the future.)

@aturon

aturon commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

Proposing FCP for stabilizing this cycle:

@rfcbot fcp merge

@nikomatsakis

nikomatsakis commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

@petrochenkov I left a comment, seems good to me

@aturonaturon mentioned this pull request Oct 4, 2016
Closed
@rfcbot

rfcbot commented Oct 4, 2016•
edited
Loading

Copy link
Copy Markdown

FCP proposed with disposition to merge. Review requested from:

No concerns currently listed.
See this document for info about what commands tagged team members can give me.

@aturon

aturon commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

Oops, I got confused and thought this was the tracking issue rather than the PR. Sorry!

@rfcbot cancel

@bors

bors commented Oct 7, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #36945) made this pull request unmergeable. Please resolve the merge conflicts.

@rfcbot

rfcbot commented Oct 13, 2016

Copy link
Copy Markdown

All relevant subteam members have reviewed. No concerns remain.

@rfcbot

rfcbot commented Oct 20, 2016

Copy link
Copy Markdown

It has been one week since all blocks to the FCP were resolved.

@nikomatsakis

nikomatsakis commented Nov 2, 2016

Copy link
Copy Markdown
Contributor

@petrochenkov FCP is over, care to rebase?

@petrochenkov

petrochenkov commented Nov 2, 2016

Copy link
Copy Markdown
ContributorAuthor

Rebased.

@nikomatsakis

nikomatsakis commented Nov 8, 2016

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 8, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 74bb594 has been approved by nikomatsakis

@bors

bors commented Nov 8, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 74bb594 with merge 722c687...

bors added a commit that referenced this pull request Nov 8, 2016
@bors
Auto merge of#36843- petrochenkov:dotstab, r=nikomatsakis
722c687
Stabilize `..` in tuple (struct) patterns
I'd like to nominate `..` in tuple and tuple struct patterns for stabilization.
This feature is a relatively small extension to existing stable functionality and doesn't have known blockers.
The feature first appeared in Rust 1.10 6 months ago.
An example of use: #36203Closes#33627
r? @nikomatsakis
@jseyfried

jseyfried commented Nov 8, 2016

Copy link
Copy Markdown
Contributor

@bors retry force

@bors

bors commented Nov 8, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 74bb594 with merge 38a959a...

bors added a commit that referenced this pull request Nov 8, 2016
@bors
Auto merge of#36843- petrochenkov:dotstab, r=nikomatsakis
38a959a
Stabilize `..` in tuple (struct) patterns
I'd like to nominate `..` in tuple and tuple struct patterns for stabilization.
This feature is a relatively small extension to existing stable functionality and doesn't have known blockers.
The feature first appeared in Rust 1.10 6 months ago.
An example of use: #36203Closes#33627
r? @nikomatsakis
@bors

bors commented Nov 8, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: nikomatsakis
Pushing 38a959a to master...

@bors
bors merged commit 74bb594 into rust-lang:masterNov 8, 2016
@borsbors mentioned this pull request Nov 8, 2016
Merged
@petrochenkov
petrochenkov deleted the dotstab branch March 16, 2017 19:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

relnotesMarks issues that should be documented in the release notes of the next release.T-langRelevant to the language team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@petrochenkov@nikomatsakis@nrc@aturon@rfcbot@bors@jseyfried@brson