Skip to content

Partially stabilize RFC 1506 "Clarify relationships between ADTs" - #36868

Merged
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:adtstab
Nov 9, 2016
Merged

Partially stabilize RFC 1506 "Clarify relationships between ADTs"#36868
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:adtstab

Conversation

@petrochenkov

@petrochenkovpetrochenkov commented Sep 30, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Lifted restrictions on tuple structs/variants are stabilized, i.e. S{..} can be used with any structs and empty tuple structs are permitted without feature gate.
Numeric fields in struct expressions/patterns S { 0: a, 1: b } are NOT stabilized.
This was implemented 1.5 months ago in Rust 1.12, but this is a tiny technical change that could probably go even without RFC/stabilization period.

cc #35626#36871
r? @nikomatsakis

@petrochenkovpetrochenkov mentioned this pull request Sep 30, 2016
Merged
@brsonbrson added relnotes Marks issues that should be documented in the release notes of the next release. I-nominated T-lang Relevant to the language team labels Sep 30, 2016
@nikomatsakis

nikomatsakis commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

cc @rust-lang/lang -- thoughts on stabilizing Foo { .. }?

@nrc

nrc commented Oct 4, 2016

Copy link
Copy Markdown
Member

Should this have an FCP cycle? I'm still in favour of the change but it does not seem like a no-brainer feature to me - it still gives me pause that braced structs can match tuple structs in patterns.

@nikomatsakis

nikomatsakis commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

@nrc I was thinking it probably should, yes.

bors added a commit that referenced this pull request Oct 11, 2016
@bors
Auto merge of#36871- petrochenkov:pdderr, r=nikomatsakis
304d0c8
Turn compatibility lint `match_of_unit_variant_via_paren_dotdot` into a hard error
The lint was introduced 10 months ago and made deny-by-default 7 months ago.
In case someone is still using it, #36868 contains a stable replacement.
r? @nikomatsakis
@alexcrichton

alexcrichton commented Oct 31, 2016

Copy link
Copy Markdown
Member

ping, is this just waiting for the FCP on an issue to close?

@petrochenkov

petrochenkov commented Nov 1, 2016

Copy link
Copy Markdown
ContributorAuthor

Yes, waiting for FCP.
Not sure though when exactly it's supposed to happen, before or after the next release.

@nikomatsakis

nikomatsakis commented Nov 2, 2016

Copy link
Copy Markdown
Contributor

@petrochenkov so FCP is over, care to rebase?

@petrochenkov

petrochenkov commented Nov 3, 2016

Copy link
Copy Markdown
ContributorAuthor

Rebased.

@nikomatsakis

nikomatsakis commented Nov 8, 2016

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 8, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit baf9f33 has been approved by nikomatsakis

@bors

bors commented Nov 8, 2016

Copy link
Copy Markdown
Collaborator

🔒 Merge conflict

@bors

bors commented Nov 8, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #36843) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov

petrochenkov commented Nov 8, 2016

Copy link
Copy Markdown
ContributorAuthor

@bors r=nikomatsakis

@bors

bors commented Nov 8, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit ab5ba04 has been approved by nikomatsakis

eddyb added a commit to eddyb/rust that referenced this pull request Nov 9, 2016
@eddyb
Rollup merge ofrust-lang#36868- petrochenkov:adtstab, r=nikomatsakis
f433209
Partially stabilize RFC 1506 "Clarify relationships between ADTs"
Lifted restrictions on tuple structs/variants are stabilized, i.e. `S{..}` can be used with any structs and empty tuple structs are permitted without feature gate.
Numeric fields in struct expressions/patterns `S { 0: a, 1: b }` are **NOT** stabilized.
This was implemented 1.5 months ago in Rust 1.12, but this is a tiny technical change that could probably go even without RFC/stabilization period.
cc rust-lang#35626rust-lang#36871
r? @nikomatsakis
@eddybeddyb mentioned this pull request Nov 9, 2016
Merged
bors added a commit that referenced this pull request Nov 9, 2016
@bors
Auto merge of#37670- eddyb:rollup, r=eddyb
da2ce22
Rollup of 15 pull requests
- Successful merges: #36868, #37134, #37229, #37250, #37370, #37428, #37432, #37472, #37524, #37614, #37622, #37627, #37636, #37644, #37654
- Failed merges: #37463, #37542, #37645
@bors
bors merged commit ab5ba04 into rust-lang:masterNov 9, 2016
@nikomatsakisnikomatsakis mentioned this pull request Nov 11, 2016
Closed
2 tasks
@petrochenkov
petrochenkov deleted the adtstab branch March 16, 2017 19:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

relnotesMarks issues that should be documented in the release notes of the next release.T-langRelevant to the language team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@petrochenkov@nikomatsakis@nrc@alexcrichton@bors@brson