Uh oh!
There was an error while loading. Please reload this page.
Syntax breaking batch - #36857
Merged
Merged
Conversation
…pe of other AstBuilder.stmt* functions
I am using `ThinAttributes` rather than a vector for attributes attached to generics, since I expect almost all lifetime and types parameters to not carry any attributes.
…ached binding in generics.
These weren't flagged by the lint because they were still technically created somewhere... if you created them before, somehow.
This applies the HIR changes from the previous commits to the AST, and is thus a syntax-[breaking-change] Renames `PatKind::Vec` to `PatKind::Slice`, since these are called slice patterns, not vec patterns. Renames `TyKind::Vec`, which represents the type `[T]`, to `TyKind::Slice`. Renames `TyKind::FixedLengthVec` to `TyKind::Array`.
Manishearth
commented
Sep 30, 2016
MemberAuthor
@bors try |
bors
commented
Sep 30, 2016
Collaborator
bors
commented
Sep 30, 2016
Collaborator
💥 Test timed out |
pnkfelix
commented
Sep 30, 2016
Contributor
@bors retry |
bors
commented
Sep 30, 2016
Collaborator
bors
commented
Oct 1, 2016
Collaborator
💥 Test timed out |
Manishearth
commented
Oct 1, 2016
MemberAuthor
@bors try- r+ retry |
bors
commented
Oct 1, 2016
Collaborator
📌 Commit 173ebc3 has been approved by |
Manishearth
commented
Oct 1, 2016
MemberAuthor
@bors p=10 |
bors
commented
Oct 1, 2016
Collaborator
⌛ Testing commit 173ebc3 with merge 5d3ae8a... |
…, r=Manishearth This commit makes the return type of AstBuilder.stmt_let_typed match the return type of other AstBuilder.stmt* functions. This avoids unnecessary boxing/unboxing whenever Stmt's are stored in a Vec, which is the default use case.nnThis is a potentially plugin breaking change.
…orite-data-structure, r=pnkfelix Contains a syntax-[breaking-change] as a separate commit (cc rust-lang#31645).nnAlso renames slice patterns from `PatKind::Vec` to `PatKind::Slice`.
…r=eddyb First step for rust-lang#34761
Manishearthforce-pushed
the
syntax-rollup
branch
from
October 1, 2016 13:53
173ebc3 to
406fe7eCompareManishearth
commented
Oct 1, 2016
MemberAuthor
@bors r+ force commit messages need r=foo |
bors
commented
Oct 1, 2016
Collaborator
📌 Commit 406fe7e has been approved by |
Manishearth
commented
Oct 1, 2016
MemberAuthor
@bors force |
bors
commented
Oct 1, 2016
Collaborator
bors
commented
Oct 1, 2016
Collaborator
This was referenced Oct 1, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.