Uh oh!
There was an error while loading. Please reload this page.
Add missing urls for io types - #37165
Merged
Merged
Conversation
GuillaumeGomez
commented
Oct 14, 2016
MemberAuthor
bors
commented
Oct 14, 2016
Collaborator
✌️ @kmcallister can now approve this pull request |
kmcallister
commented
Oct 15, 2016
Contributor
@bors: r+ rollup |
bors
commented
Oct 15, 2016
Collaborator
📌 Commit e25d997 has been approved by |
ollie27
reviewed
Oct 15, 2016
| /// The standard library implements some I/O traits on various types which | ||
| /// are commonly used as a buffer, like `Cursor<Vec<u8>>` and `Cursor<&[u8]>`. | ||
| /// are commonly used as a buffer, like `Cursor<`[`Vec`]`<u8>>` and | ||
| /// `Cursor<`[`&[u8]`]`>`. |
Contributor
There was a problem hiding this comment.
You can't put square brackets in links like this. It needs to be something like ``Cursor<[&[u8]`][bytes]`>`.` and `[bytes]: ../../std/primitive.slice.html` for this link to work.
MemberAuthor
There was a problem hiding this comment.
Didn't pay attention, thanks!
MemberAuthor
There was a problem hiding this comment.
Actually it does work.
GuillaumeGomez
commented
Oct 15, 2016
MemberAuthor
@bors: r- |
GuillaumeGomez
commented
Oct 19, 2016
MemberAuthor
@bors: r=kmcallister rollup |
bors
commented
Oct 19, 2016
Collaborator
📌 Commit e25d997 has been approved by |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Oct 19, 2016
…ster Add missing urls for io types r? @steveklabnik
bors added a commit
that referenced
this pull request
Oct 20, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @steveklabnik