Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #37289
Merged
Merged
Conversation
In rust-lang#34268 (8531d58), we replaced matches of None to the unit value `()` with `if let`s in places where it was deemed that this made the code unambiguously clearer and more idiomatic. In rust-lang#34638 (d37edef), we did the same for matches of None to the empty block `{}`. A casual observer, upon seeing these commits fly by, might suppose that the matter was then settled, that no further pull requests on this utterly trivial point of style could or would be made. Unless ... It turns out that sometimes people write the empty block with a space in between the braces. Who knew?
…ster Add missing urls for io types r? @steveklabnik
…ster Improve doc example for `std::borrow::Cow`. None
…empty_block_arm, r=nikomatsakis
prefer `if let` to match with `None => { }` arm in some places
In rust-lang#34268 (8531d58), we replaced matches of None to the unit value `()`
with `if let`s in places where it was deemed that this made the code
unambiguously clearer and more idiomatic. In rust-lang#34638 (d37edef), we did
the same for matches of None to the empty block `{}`.
A casual observer, upon seeing these commits fly by, might suppose that
the matter was then settled, that no further pull requests on this
utterly trivial point of style could or would be made. Unless ...
It turns out that sometimes people write the empty block with a space in
between the braces. Who knew?…es, r=steveklabnik Fix grammatical errors in `tests` directory docs
run rustfmt on control_flow_graph folder
run rustfmt on unify folder
run rustfmt on snapshot_map
rust-highfive
commented
Oct 19, 2016
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
GuillaumeGomez
commented
Oct 19, 2016
MemberAuthor
@bors: r+ p=1 |
bors
commented
Oct 19, 2016
Collaborator
📌 Commit dd3a014 has been approved by |
bors
commented
Oct 20, 2016
Collaborator
⌛ Testing commit dd3a014 with merge dfd98eb... |
bors added a commit
that referenced
this pull request
Oct 20, 2016
bors
commented
Oct 20, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::borrow::Cow. #37187, preferif letto match withNone => { }arm in some places #37241, Fix grammatical errors intestsdirectory docs #37283, run rustfmt on control_flow_graph folder #37285, run rustfmt on unify folder #37287, run rustfmt on snapshot_map #37288