Add .wrapping_offset() methods by bluss · Pull Request #37422 · rust-lang/rust

bluss · 2016-10-26T21:12:21Z

.wrapping_offset() exposes the arith_offset intrinsic in the core
module (as methods on raw pointers, next to offset). This is the
first step in making it possible to stabilize the interface later.

arith_offset is a useful tool for developing iterators for two
reasons:

arith_offset is used by the slice's iterator, the most important
iterator in libcore, and it is natural that Rust users need the same
power available to implement similar iterators.
It is a good way to implement raw pointer iterations with step
greater than one.

The name seems to fit the style of methods like "wrapping_add".

rust-highfive · 2016-10-26T21:12:32Z

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

.wrapping_offset() exposes the arith_offset intrinsic in the core module. This is the first step in making it possible to stabilize the interface later. `arith_offset` is a useful tool for developing iterators for two reasons: 1. `arith_offset` is used by the slice's iterator, the most important iterator in libcore, and it is natural that Rust users need the same power available to implement similar iterators. 2. It is a good way to implement raw pointer iterations with step greater than one. The name seems to fit the style of methods like "wrapping_add".

alexcrichton · 2016-10-27T14:56:33Z

Sounds great to me!

@rfcbot fcp merge

rfcbot · 2016-10-27T14:57:56Z

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2016-11-03T22:50:53Z

🔔 This is now entering its final comment period, as per the review above. 🔔

psst @alexcrichton, I wasn't able to add the final-comment-period label, please do so.

alexcrichton · 2016-11-03T22:53:19Z

Ok! @bluss want to open a tracking issue for this and I'll r+?

bluss · 2016-11-03T23:17:00Z

Great! Tracking issue is #37570

alexcrichton · 2016-11-03T23:22:23Z

@bors: r+

bors · 2016-11-03T23:22:24Z

📌 Commit 67626e0 has been approved by alexcrichton

Add .wrapping_offset() methods .wrapping_offset() exposes the arith_offset intrinsic in the core module (as methods on raw pointers, next to offset). This is the first step in making it possible to stabilize the interface later. `arith_offset` is a useful tool for developing iterators for two reasons: 1. `arith_offset` is used by the slice's iterator, the most important iterator in libcore, and it is natural that Rust users need the same power available to implement similar iterators. 2. It is a good way to implement raw pointer iterations with step greater than one. The name seems to fit the style of methods like "wrapping_add".

bors · 2016-11-05T00:48:08Z

⌛ Testing commit 67626e0 with merge e96b9d2...

Add .wrapping_offset() methods .wrapping_offset() exposes the arith_offset intrinsic in the core module (as methods on raw pointers, next to offset). This is the first step in making it possible to stabilize the interface later. `arith_offset` is a useful tool for developing iterators for two reasons: 1. `arith_offset` is used by the slice's iterator, the most important iterator in libcore, and it is natural that Rust users need the same power available to implement similar iterators. 2. It is a good way to implement raw pointer iterations with step greater than one. The name seems to fit the style of methods like "wrapping_add".

bors · 2016-11-05T04:13:07Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing e96b9d2 to master...

Rollup of 24 pull requests - Successful merges: #37255, #37317, #37408, #37410, #37422, #37427, #37470, #37501, #37537, #37556, #37557, #37564, #37565, #37566, #37569, #37574, #37577, #37579, #37583, #37585, #37586, #37587, #37589, #37596 - Failed merges: #37521, #37547

Add .wrapping_offset() methods .wrapping_offset() exposes the arith_offset intrinsic in the core module (as methods on raw pointers, next to offset). This is the first step in making it possible to stabilize the interface later. `arith_offset` is a useful tool for developing iterators for two reasons: 1. `arith_offset` is used by the slice's iterator, the most important iterator in libcore, and it is natural that Rust users need the same power available to implement similar iterators. 2. It is a good way to implement raw pointer iterations with step greater than one. The name seems to fit the style of methods like "wrapping_add".

Rollup of 24 pull requests - Successful merges: #37255, #37317, #37408, #37410, #37422, #37427, #37470, #37501, #37537, #37556, #37557, #37564, #37565, #37566, #37569, #37574, #37577, #37579, #37583, #37585, #37586, #37587, #37589, #37596 - Failed merges: #37521, #37547

rust-highfive assigned alexcrichton Oct 26, 2016

bluss force-pushed the wrapping-offset branch 2 times, most recently from 2a3eb28 to ef591e5Compare October 26, 2016 22:06

bluss force-pushed the wrapping-offset branch from ef591e5 to 8b2108cCompare October 26, 2016 22:07

alexcrichton added the T-libs-api [DEPRECATED; DO NOT USE] label Oct 27, 2016

bluss mentioned this pull request Nov 3, 2016
Tracking issue for ptr_wrapping_offset#37570
Closed

core::ptr: Specify issue for ptr_wrapping_offset feature
67626e0

sophiajt mentioned this pull request Nov 4, 2016
Rollup of 17 pull requests #37581
Closed

alexcrichton mentioned this pull request Nov 4, 2016
Rollup of 24 pull requests #37597
Merged

bors merged commit 67626e0 into rust-lang:masterNov 5, 2016

bluss deleted the wrapping-offset branch November 5, 2016 09:30

bluss mentioned this pull request Nov 26, 2016
Serialization performance regression #38021
Closed

Navigation Menu

Uh oh!

Uh oh!

Add .wrapping_offset() methods - #37422

Add .wrapping_offset() methods#37422
bors merged 2 commits into
rust-lang:masterfrom
bluss:wrapping-offset

bluss commented Oct 26, 2016

Uh oh!

rust-highfive commented Oct 26, 2016

Uh oh!

alexcrichton commented Oct 27, 2016

Uh oh!

rfcbot commented Oct 27, 2016•
edited
Loading

Uh oh!

rfcbot commented Nov 3, 2016

Uh oh!

alexcrichton commented Nov 3, 2016

Uh oh!

bluss commented Nov 3, 2016

Uh oh!

alexcrichton commented Nov 3, 2016

Uh oh!

bors commented Nov 3, 2016

Uh oh!

bors commented Nov 5, 2016

Uh oh!

bors commented Nov 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

bluss commented Oct 26, 2016

Uh oh!

rust-highfive commented Oct 26, 2016

Uh oh!

alexcrichton commented Oct 27, 2016

Uh oh!

rfcbot commented Oct 27, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Nov 3, 2016

Uh oh!

alexcrichton commented Nov 3, 2016

Uh oh!

bluss commented Nov 3, 2016

Uh oh!

alexcrichton commented Nov 3, 2016

Uh oh!

bors commented Nov 3, 2016

Uh oh!

bors commented Nov 5, 2016

Uh oh!

bors commented Nov 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rfcbot commented Oct 27, 2016•
edited
Loading