Skip to content

set frame pointer elimination attribute for main - #37556

Merged
bors merged 1 commit into
rust-lang:masterfrom
dinfuehr:main_frame_pointer
Nov 6, 2016
Merged

set frame pointer elimination attribute for main#37556
bors merged 1 commit into
rust-lang:masterfrom
dinfuehr:main_frame_pointer

Conversation

@dinfuehr

@dinfuehrdinfuehr commented Nov 3, 2016

Copy link
Copy Markdown
Contributor

The rustc-generated function main should respect the same config for
frame pointer elimination as the rest of code.

@rust-highfive

rust-highfive commented Nov 3, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@dinfuehr
set frame pointer elimination attribute for main
7d06bdd
The rustc-generated function `main` should respect the same config for
frame pointer elimination as the rest of code.
@eddyb

eddyb commented Nov 3, 2016

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Nov 3, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 7d06bdd has been approved by eddyb

@bors

bors commented Nov 3, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7d06bdd with merge 307a175...

@bors

bors commented Nov 3, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-opt-rustbuild

@alexcrichton

alexcrichton commented Nov 3, 2016

Copy link
Copy Markdown
Member

@bors: retry

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Nov 4, 2016
Jonathan Turner
Rollup merge ofrust-lang#37556- dinfuehr:main_frame_pointer, r=eddyb
be98e20
set frame pointer elimination attribute for main
The rustc-generated function `main` should respect the same config for
frame pointer elimination as the rest of code.
@sophiajtsophiajt mentioned this pull request Nov 4, 2016
Closed
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 4, 2016
@alexcrichton
Rollup merge ofrust-lang#37556- dinfuehr:main_frame_pointer, r=eddyb
0bcd5c0
set frame pointer elimination attribute for main
The rustc-generated function `main` should respect the same config for
frame pointer elimination as the rest of code.
@alexcrichtonalexcrichton mentioned this pull request Nov 4, 2016
Merged
bors added a commit that referenced this pull request Nov 5, 2016
@bors
Auto merge of#37597- alexcrichton:rollup, r=alexcrichton
16d5330
Rollup of 24 pull requests
- Successful merges: #37255, #37317, #37408, #37410, #37422, #37427, #37470, #37501, #37537, #37556, #37557, #37564, #37565, #37566, #37569, #37574, #37577, #37579, #37583, #37585, #37586, #37587, #37589, #37596
- Failed merges: #37521, #37547
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Nov 5, 2016
Jonathan Turner
Rollup merge ofrust-lang#37556- dinfuehr:main_frame_pointer, r=eddyb
ebfb0cc
set frame pointer elimination attribute for main
The rustc-generated function `main` should respect the same config for
frame pointer elimination as the rest of code.
@sophiajtsophiajt mentioned this pull request Nov 5, 2016
Closed
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 5, 2016
@alexcrichton
Rollup merge ofrust-lang#37556- dinfuehr:main_frame_pointer, r=eddyb
ee90485
set frame pointer elimination attribute for main
The rustc-generated function `main` should respect the same config for
frame pointer elimination as the rest of code.
bors added a commit that referenced this pull request Nov 6, 2016
@bors
Auto merge of#37597- alexcrichton:rollup, r=alexcrichton
3fc8304
Rollup of 24 pull requests
- Successful merges: #37255, #37317, #37408, #37410, #37422, #37427, #37470, #37501, #37537, #37556, #37557, #37564, #37565, #37566, #37569, #37574, #37577, #37579, #37583, #37585, #37586, #37587, #37589, #37596
- Failed merges: #37521, #37547
@bors
bors merged commit 7d06bdd into rust-lang:masterNov 6, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@AatchAatch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dinfuehr@rust-highfive@eddyb@bors@alexcrichton@Aatch