Uh oh!
There was an error while loading. Please reload this page.
Warn when an import list is empty - #38085
Merged
Merged
Conversation
rust-highfive
commented
Nov 30, 2016
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
estebankforce-pushed
the
empty-import-list-fix-38012
branch
from
November 30, 2016 08:18
beb8a4c to
e8b5edeComparepetrochenkov
commented
Nov 30, 2016
Contributor
bors
commented
Nov 30, 2016
Collaborator
☔ The latest upstream changes (presumably #38014) made this pull request unmergeable. Please resolve the merge conflicts. |
eddyb
commented
Nov 30, 2016
Contributor
r? @jseyfried |
jseyfried
commented
Dec 5, 2016
Contributor
@estebank Could you make this an |
ContributorAuthor
@jseyfried done! |
estebankforce-pushed
the
empty-import-list-fix-38012
branch
3 times, most recently
from
December 5, 2016 22:24
b0e17c8 to
b4eca19CompareFor a given file
```rust
use std::*;
use std::{};
```
output the following warnings
```
warning: unused import: `use std::{};`, #[warn(unused_imports)] on by default
--> file.rs:2:1
|
2 | use std::{};
| ^^^^^^^^^^^^
warning: unused import: `std::*;`, #[warn(unused_imports)] on by default
--> file.rs:1:5
|
1 | use std::*;
| ^^^^^^^
```estebankforce-pushed
the
empty-import-list-fix-38012
branch
from
December 6, 2016 01:20
b4eca19 to
58e70e7Comparejseyfried
commented
Dec 6, 2016
Contributor
bors
commented
Dec 6, 2016
Collaborator
📌 Commit 58e70e7 has been approved by |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 7, 2016
…2, r=jseyfried
Warn when an import list is empty
For a given file
```rust
use std::*;
use std::{};
```
output the following warnings
```
warning: unused import: `use std::{};`, #[warn(unused_imports)] on by default
--> file.rs:2:1
|
2 | use std::{};
| ^^^^^^^^^^^^
warning: unused import: `std::*;`, #[warn(unused_imports)] on by default
--> file.rs:1:5
|
1 | use std::*;
| ^^^^^^^
```bors added a commit
that referenced
this pull request
Dec 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a given file
output the following warnings