Skip to content

Add docs for last undocumented Defaultimpl. - #38186

Merged
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:default
Dec 7, 2016
Merged

Add docs for last undocumented Defaultimpl.#38186
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:default

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Dec 5, 2016

Copy link
Copy Markdown
Contributor

Add doc comment for Defaultimpl on DefaultHasher.

Fixes#36265.

@rust-highfive

rust-highfive commented Dec 5, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcvfrewsxcv mentioned this pull request Dec 5, 2016
Closed
@frewsxcv

frewsxcv commented Dec 5, 2016

Copy link
Copy Markdown
ContributorAuthor

r? @GuillaumeGomez

GuillaumeGomez
GuillaumeGomez reviewed Dec 6, 2016
View reviewed changes
Comment threadsrc/libstd/collections/hash/map.rs Outdated

@GuillaumeGomezGuillaumeGomezDec 6, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that "the" is need in here.

@frewsxcvfrewsxcvDec 7, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@GuillaumeGomez

GuillaumeGomez commented Dec 7, 2016

Copy link
Copy Markdown
Member

Thanks!

@bors: r+ rollup

@bors

bors commented Dec 7, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 3cd9868 has been approved by GuillaumeGomez

@GuillaumeGomezGuillaumeGomez mentioned this pull request Dec 7, 2016
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 7, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#38186- frewsxcv:default, r=GuillaumeGomez
ccbeb6d
Add docs for last undocumented `Default` `impl`.
Add doc comment for `Default` `impl` on `DefaultHasher`.
Fixesrust-lang#36265.
bors added a commit that referenced this pull request Dec 7, 2016
@bors
Auto merge of#38214- GuillaumeGomez:rollup, r=GuillaumeGomez
535b6d3
Rollup of 9 pull requests
- Successful merges: #38085, #38123, #38151, #38153, #38158, #38163, #38186, #38189, #38208
- Failed merges:
@bors
bors merged commit 3cd9868 into rust-lang:masterDec 7, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez left review comments

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@frewsxcv@rust-highfive@GuillaumeGomez@bors@alexcrichton