Uh oh!
There was an error while loading. Please reload this page.
resolve: change most backwards incompatible ambiguity errors to legacy_imports warnings - #38271
Merged
Merged
Conversation
3 tasks
jseyfriedforce-pushed
the
rfc_1560_warning_cycle
branch
from
December 10, 2016 03:48
162e61d to
1993a07Comparejseyfriedforce-pushed
the
rfc_1560_warning_cycle
branch
from
December 15, 2016 06:03
1993a07 to
cfabce2Comparealexcrichton
commented
Dec 15, 2016
Member
ping @nrc / @nikomatsakis, would be great to get this in before beta! |
alexcrichton
commented
Dec 15, 2016
Member
Nominating for beta to ensure we don't forget about this if it misses the beta branch. Note that this should only go into 1.15.0 beta, not the current (as of this writing) 1.14.0 beta. |
nrc
commented
Dec 20, 2016
Member
@bors: r+ |
bors
commented
Dec 20, 2016
Collaborator
📌 Commit cfabce2 has been approved by |
bors
commented
Dec 20, 2016
Collaborator
bors added a commit
that referenced
this pull request
Dec 20, 2016
resolve: change most backwards incompatible ambiguity errors to `legacy_imports` warnings Fixes#38176. r? @nrc or @nikomatsakis
bors
commented
Dec 20, 2016
Collaborator
bors added a commit
that referenced
this pull request
Dec 20, 2016
Rollup of 29 pull requests - Successful merges: #37761, #38006, #38131, #38150, #38158, #38171, #38208, #38215, #38236, #38245, #38289, #38302, #38315, #38346, #38388, #38395, #38398, #38418, #38432, #38451, #38463, #38468, #38470, #38471, #38472, #38478, #38486, #38493, #38498 - Failed merges: #38271, #38483
nikomatsakis
commented
Dec 30, 2016
Contributor
Marking as beta-accepted. Patch is kind of medium-ish, but this is a serious regression, and mostly the patch is converting errors into lints. cc @rust-lang/compiler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#38176.
r? @nrc or @nikomatsakis