Skip to content

Add prefix to config.toml - #38388

Merged
bors merged 4 commits into
rust-lang:masterfrom
redox-os:config_toml_prefix
Dec 21, 2016
Merged

Add prefix to config.toml#38388
bors merged 4 commits into
rust-lang:masterfrom
redox-os:config_toml_prefix

Conversation

@jackpot51

Copy link
Copy Markdown
Contributor

This allows rustbuild to be used to install to a prefix.

[build]
prefix = "/path/to/install"

For example, the following config.toml will cause x.py dist --install to install to /path/to/install

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@jackpot51

Copy link
Copy Markdown
ContributorAuthor

r? @alexcrichton

@alexcrichton

Copy link
Copy Markdown
Member

Thanks! This may actually be a good time to start a new section of config.toml, [install]. I suspect we'll want a whole litany of other options in there eventually as well (aka libdir, etc). With that though sounds good to me.

@jackpot51

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton Sounds good.

Comment threadsrc/bootstrap/config.toml.example Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"installing installing"

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I fixed it

@jackpot51

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton I have made the change, adding an [install] section that contains prefix

@alexcrichton

Copy link
Copy Markdown
Member

Looks good to me! It appears tidy has a problem though?

@jackpot51

Copy link
Copy Markdown
ContributorAuthor

I will fix the tidy issue - thanks

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Dec 20, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 228e495 has been approved by alexcrichton

@jackpot51

Copy link
Copy Markdown
ContributorAuthor

Thanks @alexcrichton !

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 20, 2016
…crichton
Add prefix to config.toml
This allows `rustbuild` to be used to install to a prefix.
```toml
[build]
prefix = "/path/to/install"
```
For example, the following `config.toml` will cause `x.py dist --install` to install to `/path/to/install`
bors added a commit that referenced this pull request Dec 20, 2016
@bors
bors merged commit 228e495 into rust-lang:masterDec 21, 2016
@jackpot51
jackpot51 deleted the config_toml_prefix branch December 21, 2016 04:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@jackpot51@rust-highfive@alexcrichton@bors@frewsxcv@aturon